Bump lowest possible min for numeric parameters to -DBL_MAX + 1

nyalldawson · nyalldawson · commit 297e8561a06d · 2017-12-01T20:42:38.000+11:00
We need to reserve -DBL_MAX as a special value, to allow it to
work correctly in QDoubleSpinBoxes (limitation of QDoubleSpinBox)
diff --git a/python/core/processing/qgsprocessingparameters.sip b/python/core/processing/qgsprocessingparameters.sip
@@ -1129,7 +1129,7 @@ class QgsProcessingParameterNumber : QgsProcessingParameterDefinition
                                            Type type = Integer,
                                            const QVariant &defaultValue = QVariant(),
                                            bool optional = false,
-                                           double minValue = -DBL_MAX,
+                                           double minValue = -DBL_MAX + 1,
                                            double maxValue = DBL_MAX
                                          );
 %Docstring
diff --git a/src/core/processing/qgsprocessingparameters.cpp b/src/core/processing/qgsprocessingparameters.cpp
@@ -2003,7 +2003,7 @@ QString QgsProcessingParameterNumber::toolTip() const
 {
   QString text = QgsProcessingParameterDefinition::toolTip();
   QStringList parts;
-  if ( mMin > -DBL_MAX )
+  if ( mMin > -DBL_MAX + 1 )
     parts << QObject::tr( "Minimum value: %1" ).arg( mMin );
   if ( mMax < DBL_MAX )
     parts << QObject::tr( "Maximum value: %1" ).arg( mMax );
diff --git a/src/core/processing/qgsprocessingparameters.h b/src/core/processing/qgsprocessingparameters.h
@@ -1099,7 +1099,7 @@ class CORE_EXPORT QgsProcessingParameterNumber : public QgsProcessingParameterDe
                                            Type type = Integer,
                                            const QVariant &defaultValue = QVariant(),
                                            bool optional = false,
-                                           double minValue = -DBL_MAX,
+                                           double minValue = -DBL_MAX + 1,
                                            double maxValue = DBL_MAX
                                          );
 
@@ -1159,7 +1159,7 @@ class CORE_EXPORT QgsProcessingParameterNumber : public QgsProcessingParameterDe
 
   private:
 
-    double mMin = -DBL_MAX;
+    double mMin = -DBL_MAX + 1;
     double mMax = DBL_MAX;
     Type mDataType = Integer;
 };

Original file line number	Diff line number	Diff line change
`@@ -2003,7 +2003,7 @@ QString QgsProcessingParameterNumber::toolTip() const`
`2003`	`2003`	`{`
`2004`	`2004`	`QString text = QgsProcessingParameterDefinition::toolTip();`
`2005`	`2005`	`QStringList parts;`
`2006`		`- if ( mMin > -DBL_MAX )`
	`2006`	`+ if ( mMin > -DBL_MAX + 1 )`
`2007`	`2007`	`parts << QObject::tr( "Minimum value: %1" ).arg( mMin );`
`2008`	`2008`	`if ( mMax < DBL_MAX )`
`2009`	`2009`	`parts << QObject::tr( "Maximum value: %1" ).arg( mMax );`