fix #2869

git-svn-id: http://svn.osgeo.org/qgis/trunk@13893 c8812cc2-4d05-0410-92ff-de0c093fc19c
qgis · Jul 6, 2010 · 295f1e0 · 295f1e0
1 parent dde5865
commit 295f1e0
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 14 deletions.
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -1,13 +1,14 @@
 /***************************************************************************
                                qgsvectorlayer.cpp
+                              --------------------
+          begin                : Oct 29, 2003
+          copyright            : (C) 2003 by Gary E.Sherman
+          email                : sherman at mrcc.com
+
   This class implements a generic means to display vector layers. The features
   and attributes are read from the data store using a "data provider" plugin.
   QgsVectorLayer can be used with any data store for which an appropriate
   plugin is available.
-                              -------------------
-          begin                : Oct 29, 2003
-          copyright            : (C) 2003 by Gary E.Sherman
-          email                : sherman at mrcc.com
 
 ***************************************************************************/
 

diff --git a/src/core/qgsvectoroverlay.h b/src/core/qgsvectoroverlay.h
@@ -25,16 +25,21 @@ class QgsOverlayObject;
 class QgsRect;
 class QgsRenderContext;
 
-/**Base class for vector layer overlays (e.g. Diagrams, labels, etc.). For each object, the position of the bounding box is *stored in a QgsOberlayObject. The vector overlays are drawn on top of all layers
-* \note This class has been added in version 1.1
-*/
+/**Base class for vector layer overlays (e.g. diagrams, labels, etc.). For each
+ * object, the position of the bounding box is stored in a QgsOverlayObject.
+ * The vector overlays are drawn on top of all layers.
+ * \note This class has been added in version 1.1
+ */
 class CORE_EXPORT QgsVectorOverlay
 {
   public:
     QgsVectorOverlay( QgsVectorLayer* vl );
     virtual ~QgsVectorOverlay();
 
-    /**Create the overlay objects contained in a view extent. Subclasses need to implement this method and assign                   width/height information to the overlay ovbjects*/
+    /**Create the overlay objects contained in a view extent. Subclasses need
+     * to implement this method and assign width/height information to the
+     * overlay objects
+     */
 
     virtual void createOverlayObjects( const QgsRenderContext& renderContext ) = 0;
 

diff --git a/src/plugins/diagram_overlay/qgswkndiagramfactorywidget.cpp b/src/plugins/diagram_overlay/qgswkndiagramfactorywidget.cpp
@@ -121,10 +121,13 @@ void QgsWKNDiagramFactoryWidget::setExistingFactory( const QgsDiagramFactory* f
 
 void QgsWKNDiagramFactoryWidget::addAttribute()
 {
-  QTreeWidgetItem* newItem = new QTreeWidgetItem( mAttributesTreeWidget );
+  QString currentText = mAttributesComboBox->currentText();
+  if ( currentText.isEmpty() )
+    return;
+
+  QTreeWidgetItem *newItem = new QTreeWidgetItem( mAttributesTreeWidget );
 
   //text
-  QString currentText = mAttributesComboBox->currentText();
   newItem->setText( 0, currentText );
 
   //and icon
@@ -134,10 +137,7 @@ void QgsWKNDiagramFactoryWidget::addAttribute()
   QColor randomColor( red, green, blue );
   newItem->setBackground( 1, QBrush( randomColor ) );
 
-  if ( !currentText.isNull() && !currentText.isEmpty() )
-  {
-    mAttributesTreeWidget->addTopLevelItem( newItem );
-  }
+  mAttributesTreeWidget->addTopLevelItem( newItem );
 }
 
 void QgsWKNDiagramFactoryWidget::removeAttribute()