Fix rule based renderer shows 0 count on first click of "show counts"

nyalldawson · nyalldawson · commit 291f7bdaa3d6 · 2016-10-03T13:00:37.000+10:00
diff --git a/src/gui/symbology-ng/qgsrulebasedrendererwidget.cpp b/src/gui/symbology-ng/qgsrulebasedrendererwidget.cpp
@@ -517,8 +517,6 @@ void QgsRuleBasedRendererWidget::countFeatures()
     countMap[rule].duplicateCount = 0;
   }
 
-  QgsFeatureRequest req = QgsFeatureRequest().setFilterExpression( mRenderer->filter( mLayer->fields() ) );
-
   QgsRenderContext renderContext;
   renderContext.setRendererScale( 0 ); // ignore scale
 
@@ -543,10 +541,11 @@ void QgsRuleBasedRendererWidget::countFeatures()
   }
 
   renderContext.setExpressionContext( context );
-  req.setExpressionContext( context );
 
   mRenderer->startRender( renderContext, mLayer->fields() );
-
+  // QgsRuleBasedRenderer::filter must be called after startRender
+  QgsFeatureRequest req = QgsFeatureRequest().setFilterExpression( mRenderer->filter( mLayer->fields() ) );
+  req.setExpressionContext( context );
   req.setSubsetOfAttributes( mRenderer->usedAttributes(), mLayer->fields() );
   QgsFeatureIterator fit = mLayer->getFeatures( req );
 
