Limit the maximum width of legend embedded widgets

dakcarto · dakcarto · commit 26b86bae3be5 · 2019-06-14T15:32:49.000-06:00
Since column is resized to contents, limit the expanded width of
embedded widgets, if they are not already limited.

Else, embedded widget may grow very wide due to large legend graphics.
diff --git a/src/gui/layertree/qgslayertreeview.cpp b/src/gui/layertree/qgslayertreeview.cpp
@@ -159,7 +159,16 @@ void QgsLayerTreeView::modelRowsInserted( const QModelIndex &index, int start, i
         if ( QgsLayerTreeEmbeddedWidgetProvider *provider = QgsGui::layerTreeEmbeddedWidgetRegistry()->provider( providerId ) )
         {
           QModelIndex index = layerTreeModel()->legendNode2index( legendNodes[i] );
-          setIndexWidget( index, provider->createWidget( layer, i ) );
+          QWidget *wdgt = provider->createWidget( layer, i );
+          // Since column is resized to contents, limit the expanded width of embedded widgets,
+          // if they are not already limited, e.g. have the defaut MAX value.
+          // Else, embedded widget may grow very wide due to large legend graphics.
+          // TODO: Max width could be a configured setting.
+          if ( wdgt->maximumWidth() == QWIDGETSIZE_MAX )
+          {
+            wdgt->setMaximumWidth( 250 );
+          }
+          setIndexWidget( index, wdgt );
         }
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,16 @@ void QgsLayerTreeView::modelRowsInserted( const QModelIndex &index, int start, i`
`159`	`159`	`if ( QgsLayerTreeEmbeddedWidgetProvider *provider = QgsGui::layerTreeEmbeddedWidgetRegistry()->provider( providerId ) )`
`160`	`160`	`{`
`161`	`161`	`QModelIndex index = layerTreeModel()->legendNode2index( legendNodes[i] );`
`162`		`- setIndexWidget( index, provider->createWidget( layer, i ) );`
	`162`	`+ QWidget *wdgt = provider->createWidget( layer, i );`
	`163`	`+ // Since column is resized to contents, limit the expanded width of embedded widgets,`
	`164`	`+ // if they are not already limited, e.g. have the defaut MAX value.`
	`165`	`+ // Else, embedded widget may grow very wide due to large legend graphics.`
	`166`	`+ // TODO: Max width could be a configured setting.`
	`167`	`+ if ( wdgt->maximumWidth() == QWIDGETSIZE_MAX )`
	`168`	`+ {`
	`169`	`+ wdgt->setMaximumWidth( 250 );`
	`170`	`+ }`
	`171`	`+ setIndexWidget( index, wdgt );`
`163`	`172`	`}`
`164`	`173`	`}`
`165`	`174`	`}`