Allow REQUEST_BODY in tests even if QGISDEBUG is off

elpaso · elpaso · commit 2641b3fe207a · 2019-01-22T12:14:42.000+01:00
diff --git a/src/server/qgsfcgiserverrequest.cpp b/src/server/qgsfcgiserverrequest.cpp
@@ -139,7 +139,10 @@ void QgsFcgiServerRequest::readData()
   {
     bool success = false;
     int length = QString( lengthstr ).toInt( &success );
-#ifdef QGISDEBUG
+    // Note: REQUEST_BODY is not part of CGI standard, and it is not
+    // normally passed by any CGI web server and it is implemented only
+    // to allow unit tests to inject a request body and simulate a POST
+    // request
     const char *request_body  = getenv( "REQUEST_BODY" );
     if ( success && request_body )
     {
@@ -148,6 +151,7 @@ void QgsFcgiServerRequest::readData()
       mData.append( body.toUtf8() );
       length = 0;
     }
+#ifdef QGISDEBUG
     qDebug() << "fcgi: reading " << lengthstr << " bytes from " << ( request_body ? "REQUEST_BODY" : "stdin" );
 #endif
     if ( success )

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,10 @@ void QgsFcgiServerRequest::readData()`
`139`	`139`	`{`
`140`	`140`	`bool success = false;`
`141`	`141`	`int length = QString( lengthstr ).toInt( &success );`
`142`		`-#ifdef QGISDEBUG`
	`142`	`+ // Note: REQUEST_BODY is not part of CGI standard, and it is not`
	`143`	`+ // normally passed by any CGI web server and it is implemented only`
	`144`	`+ // to allow unit tests to inject a request body and simulate a POST`
	`145`	`+ // request`
`143`	`146`	`const char *request_body = getenv( "REQUEST_BODY" );`
`144`	`147`	`if ( success && request_body )`
`145`	`148`	`{`
`@@ -148,6 +151,7 @@ void QgsFcgiServerRequest::readData()`
`148`	`151`	`mData.append( body.toUtf8() );`
`149`	`152`	`length = 0;`
`150`	`153`	`}`
	`154`	`+#ifdef QGISDEBUG`
`151`	`155`	`qDebug() << "fcgi: reading " << lengthstr << " bytes from " << ( request_body ? "REQUEST_BODY" : "stdin" );`
`152`	`156`	`#endif`
`153`	`157`	`if ( success )`