[OGR] fix feature count issue for OSM datasets (fixes #16402) (#4322)

qgis · Apr 6, 2017 · 25d9936 · 25d9936
1 parent b601467
commit 25d9936
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/python/core/qgsvectordataprovider.sip b/python/core/qgsvectordataprovider.sip
@@ -57,6 +57,17 @@ class QgsVectorDataProvider : QgsDataProvider
     /** Bitmask of all provider's editing capabilities */
     static const int EditingCapabilities;
 
+    /**
+     * Enumeration of feature count states
+     */
+    enum FeatureCountState
+    {
+      //! Feature count not yet computed
+      Uncounted = -2,
+      //! Provider returned an unknown feature count
+      UnknownCount = -1,
+    };
+
     /**
      * Constructor of the vector provider
      * @param uri  uniform resource locator (URI) for a dataset

diff --git a/src/core/qgsvectordataprovider.h b/src/core/qgsvectordataprovider.h
@@ -112,6 +112,17 @@ class CORE_EXPORT QgsVectorDataProvider : public QgsDataProvider
                                            ChangeAttributeValues | ChangeGeometries | AddAttributes | DeleteAttributes |
                                            RenameAttributes;
 
+    /**
+     * Enumeration of feature count states
+     */
+    enum FeatureCountState
+    {
+      //! Feature count not yet computed
+      Uncounted = -2,
+      //! Provider returned an unknown feature count
+      UnknownCount = -1,
+    };
+
     /**
      * Constructor of the vector provider
      * \param uri  uniform resource locator (URI) for a dataset

diff --git a/src/providers/ogr/qgsogrprovider.cpp b/src/providers/ogr/qgsogrprovider.cpp
@@ -378,7 +378,7 @@ QgsOgrProvider::QgsOgrProvider( QString const &uri )
   , ogrDriver( nullptr )
   , mValid( false )
   , mOGRGeomType( wkbUnknown )
-  , mFeaturesCounted( -1 )
+  , mFeaturesCounted( QgsVectorDataProvider::Uncounted )
   , mWriteAccess( false )
   , mWriteAccessPossible( false )
   , mDynamicWriteAccess( false )
@@ -450,7 +450,7 @@ bool QgsOgrProvider::setSubsetString( const QString &theSQL, bool updateFeatureC
   if ( !ogrDataSource )
     return false;
 
-  if ( theSQL == mSubsetString && mFeaturesCounted >= 0 )
+  if ( theSQL == mSubsetString && mFeaturesCounted != QgsVectorDataProvider::Uncounted )
     return true;
 
   OGRLayerH prevLayer = ogrLayer;
@@ -3300,7 +3300,7 @@ void QgsOgrProvider::recalculateFeatureCount()
 {
   if ( !ogrLayer )
   {
-    mFeaturesCounted = 0;
+    mFeaturesCounted = QgsVectorDataProvider::Uncounted;
     return;
   }
 
@@ -3316,6 +3316,10 @@ void QgsOgrProvider::recalculateFeatureCount()
   if ( mOgrGeometryTypeFilter == wkbUnknown )
   {
     mFeaturesCounted = OGR_L_GetFeatureCount( ogrLayer, true );
+    if ( mFeaturesCounted == -1 )
+    {
+      mFeaturesCounted = QgsVectorDataProvider::UnknownCount;
+    }
   }
   else
   {