Const copy in for loop

elpaso · elpaso · commit 258b9a5a8a23 · 2019-04-04T13:53:15.000+02:00
diff --git a/src/server/services/wms/qgswmsrendercontext.cpp b/src/server/services/wms/qgswmsrendercontext.cpp
@@ -366,7 +366,8 @@ void QgsWmsRenderContext::searchLayersToRender()
 
   if ( mFlags & AddQueryLayers )
   {
-    for ( const QString &layer : flattenedQueryLayers() )
+    const auto constLayers { flattenedQueryLayers() };
+    for ( const QString &layer : constLayers )
     {
       if ( mNicknameLayers.contains( layer )
            && !mLayersToRender.contains( mNicknameLayers[layer] ) )
diff --git a/src/server/services/wms/qgswmsrendercontext.h b/src/server/services/wms/qgswmsrendercontext.h
@@ -194,7 +194,7 @@ namespace QgsWms
 #endif
 
       /**
-       * Returns a map having layer group names as keys and a list of layer instances as values.
+       * Returns a map having layer group names as keys and a list of layers as values.
        * \since QGIS 3.8
        */
       QMap<QString, QList<QgsMapLayer *> > layerGroups() const;

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,8 @@ void QgsWmsRenderContext::searchLayersToRender()`
`366`	`366`
`367`	`367`	`if ( mFlags & AddQueryLayers )`
`368`	`368`	`{`
`369`		`- for ( const QString &layer : flattenedQueryLayers() )`
	`369`	`+ const auto constLayers { flattenedQueryLayers() };`
	`370`	`+ for ( const QString &layer : constLayers )`
`370`	`371`	`{`
`371`	`372`	`if ( mNicknameLayers.contains( layer )`
`372`	`373`	`&& !mLayersToRender.contains( mNicknameLayers[layer] ) )`