Make features valid on setAttribute and setGeometry

m-kuhn · m-kuhn · commit 255eb98be61d · 2017-03-18T12:11:52.000+01:00
Implements qgis/qgis4.0_api#75
diff --git a/src/core/qgsfeature.cpp b/src/core/qgsfeature.cpp
@@ -142,12 +142,14 @@ void QgsFeature::setAttributes( const QgsAttributes &attrs )
 
   d.detach();
   d->attributes = attrs;
+  d->valid = true;
 }
 
 void QgsFeature::setGeometry( const QgsGeometry &geometry )
 {
   d.detach();
   d->geometry = geometry;
+  d->valid = true;
 }
 
 void QgsFeature::clearGeometry()
@@ -220,6 +222,7 @@ bool QgsFeature::setAttribute( int idx, const QVariant &value )
 
   d.detach();
   d->attributes[idx] = value;
+  d->valid = true;
   return true;
 }
 
@@ -237,6 +240,7 @@ bool QgsFeature::setAttribute( const QString &name, const QVariant &value )
 
   d.detach();
   d->attributes[fieldIdx] = value;
+  d->valid = true;
   return true;
 }
 
diff --git a/src/core/qgsfeature.h b/src/core/qgsfeature.h
@@ -196,13 +196,15 @@ class CORE_EXPORT QgsFeature
     QgsAttributes attributes() const;
 
     /** Sets the feature's attributes.
+     * The feature will be valid after.
      * @param attrs attribute list
      * @see setAttribute
      * @see attributes
      */
     void setAttributes( const QgsAttributes &attrs );
 
     /** Set an attribute's value by field index.
+     * The feature will be valid if it was successful.
      * @param field the index of the field to set
      * @param attr the value of the attribute
      * @return false, if the field index does not exist
@@ -251,7 +253,7 @@ class CORE_EXPORT QgsFeature
      */
     QgsGeometry geometry() const;
 
-    /** Set the feature's geometry.
+    /** Set the feature's geometry. The feature will be valid after.
      * @param geometry new feature geometry
      * @see geometry()
      * @see clearGeometry()
@@ -282,6 +284,7 @@ class CORE_EXPORT QgsFeature
 
     /** Insert a value into attribute. Returns false if attribute name could not be converted to index.
      *  Field map must be associated using @link setFields @endlink before this method can be used.
+     *  The feature will be valid if it was successful
      *  @param name The name of the field to set
      *  @param value The value to set
      *  @return false if attribute name could not be converted to index (C++ only)
diff --git a/tests/src/python/test_qgsfeature.py b/tests/src/python/test_qgsfeature.py
@@ -46,6 +46,27 @@ def test_ValidFeature(self):
         myMessage = '\nExpected: %s\nGot: %s' % ("True", myValidValue)
         assert myValidValue, myMessage
 
+    def test_Validity(self):
+        f = QgsFeature()
+        self.assertFalse(f.isValid())
+        f.setGeometry(QgsGeometry())
+        self.assertTrue(f.isValid())
+        f.setValid(False)
+        self.assertFalse(f.isValid())
+        fields = QgsFields()
+        field1 = QgsField('my_field')
+        fields.append(field1)
+        field2 = QgsField('my_field2')
+        fields.append(field2)
+        f.setFields(fields)
+        f.setAttribute(0, 0)
+        self.assertTrue(f.isValid())
+        f.setValid(False)
+        self.assertFalse(f.isValid())
+
+        f.setValid(False)
+        self.assertFalse(f.isValid())
+
     def test_Attributes(self):
         myPath = os.path.join(unitTestDataPath(), 'lines.shp')
         myLayer = QgsVectorLayer(myPath, 'Lines', 'ogr')

Original file line number	Diff line number	Diff line change
`@@ -142,12 +142,14 @@ void QgsFeature::setAttributes( const QgsAttributes &attrs )`
`142`	`142`
`143`	`143`	`d.detach();`
`144`	`144`	`d->attributes = attrs;`
	`145`	`+ d->valid = true;`
`145`	`146`	`}`
`146`	`147`
`147`	`148`	`void QgsFeature::setGeometry( const QgsGeometry &geometry )`
`148`	`149`	`{`
`149`	`150`	`d.detach();`
`150`	`151`	`d->geometry = geometry;`
	`152`	`+ d->valid = true;`
`151`	`153`	`}`
`152`	`154`
`153`	`155`	`void QgsFeature::clearGeometry()`
`@@ -220,6 +222,7 @@ bool QgsFeature::setAttribute( int idx, const QVariant &value )`
`220`	`222`
`221`	`223`	`d.detach();`
`222`	`224`	`d->attributes[idx] = value;`
	`225`	`+ d->valid = true;`
`223`	`226`	`return true;`
`224`	`227`	`}`
`225`	`228`
`@@ -237,6 +240,7 @@ bool QgsFeature::setAttribute( const QString &name, const QVariant &value )`
`237`	`240`
`238`	`241`	`d.detach();`
`239`	`242`	`d->attributes[fieldIdx] = value;`
	`243`	`+ d->valid = true;`
`240`	`244`	`return true;`
`241`	`245`	`}`
`242`	`246`