[processing] Fix model to python when model has no input parameters

qgis · Oct 30, 2019 · 254fced · 254fced
1 parent be92b23
commit 254fced
Showing 1 changed file with 17 additions and 10 deletions.
diff --git a/src/core/processing/models/qgsprocessingmodelalgorithm.cpp b/src/core/processing/models/qgsprocessingmodelalgorithm.cpp
@@ -432,19 +432,26 @@ QStringList QgsProcessingModelAlgorithm::asPythonCode( const QgsProcessing::Pyth
 
       // initAlgorithm, parameter definitions
       lines << indent + QStringLiteral( "def initAlgorithm(self, config=None):" );
-      lines.reserve( lines.size() + params.size() );
-      for ( const QgsProcessingParameterDefinition *def : params )
+      if ( params.empty() )
       {
-        std::unique_ptr< QgsProcessingParameterDefinition > defClone( def->clone() );
-
-        if ( defClone->isDestination() )
+        lines << indent + indent + QStringLiteral( "pass" );
+      }
+      else
+      {
+        lines.reserve( lines.size() + params.size() );
+        for ( const QgsProcessingParameterDefinition *def : params )
         {
-          const QString &friendlyName = !defClone->description().isEmpty() ? uniqueSafeName( defClone->description(), true, friendlyOutputNames ) : defClone->name();
-          friendlyOutputNames.insert( defClone->name(), friendlyName );
-          defClone->setName( friendlyName );
-        }
+          std::unique_ptr< QgsProcessingParameterDefinition > defClone( def->clone() );
 
-        lines << indent + indent + QStringLiteral( "self.addParameter(%1)" ).arg( defClone->asPythonString() );
+          if ( defClone->isDestination() )
+          {
+            const QString &friendlyName = !defClone->description().isEmpty() ? uniqueSafeName( defClone->description(), true, friendlyOutputNames ) : defClone->name();
+            friendlyOutputNames.insert( defClone->name(), friendlyName );
+            defClone->setName( friendlyName );
+          }
+
+          lines << indent + indent + QStringLiteral( "self.addParameter(%1)" ).arg( defClone->asPythonString() );
+        }
       }
 
       lines << QString();