QgsLayoutAtlasWidget: Disconnect signals when layout RIP

Fixes #29821
qgis · May 27, 2019 · 254569d · 254569d
1 parent 26f8815
commit 254569d
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/app/layout/qgslayoutatlaswidget.cpp b/src/app/layout/qgslayoutatlaswidget.cpp
@@ -65,6 +65,14 @@ QgsLayoutAtlasWidget::QgsLayoutAtlasWidget( QWidget *parent, QgsPrintLayout *lay
   }
   connect( mAtlasFileFormat, static_cast<void ( QComboBox::* )( int )>( &QComboBox::currentIndexChanged ), this, [ = ]( int ) { changeFileFormat(); } );
 
+  // Disconnect when layout is destroyed
+  connect( layout, &QgsPrintLayout::destroyed, [ = ]
+  {
+    disconnect( mAtlasCoverageLayerComboBox, &QgsMapLayerComboBox::layerChanged, mAtlasSortExpressionWidget, &QgsFieldExpressionWidget::setLayer );
+    disconnect( mAtlasCoverageLayerComboBox, &QgsMapLayerComboBox::layerChanged, mPageNameWidget, &QgsFieldExpressionWidget::setLayer );
+    disconnect( mAtlasCoverageLayerComboBox, &QgsMapLayerComboBox::layerChanged, this, &QgsLayoutAtlasWidget::changeCoverageLayer );
+  } );
+
   updateGuiElements();
 }