Fix missing maximize button for attribute form dialog on Windows

elpaso · github-actions[bot] · commit 244c496b4bdc · 2023-03-03T08:08:31.000Z
On  windows, the attribute form dialog misses the maximize button which can be very useful with large custom forms.

I've tried all possible combination of flags and even a custom windows API event manager but I couldn't make  the maximize button appear when the Qt::Tool flag is set.
diff --git a/src/app/qgsfeatureaction.cpp b/src/app/qgsfeatureaction.cpp
@@ -68,7 +68,11 @@ QgsAttributeDialog *QgsFeatureAction::newDialog( bool cloneFeature )
   context.setFormMode( QgsAttributeEditorContext::StandaloneDialog );
 
   QgsAttributeDialog *dialog = new QgsAttributeDialog( mLayer, f, cloneFeature, parentWidget(), true, context );
+
+  //* Skip this code on windows, because the Qt::Tool flag prevents the maximize button to be shown
+#ifndef Q_OS_WIN
   dialog->setWindowFlags( dialog->windowFlags() | Qt::Tool );
+#endif
 
   dialog->setObjectName( QStringLiteral( "featureactiondlg:%1:%2" ).arg( mLayer->id() ).arg( f->id() ) );
 
