Fix for msys shell not launching due to spaces in paths / filenames

timlinux · timlinux · commit 244681bc7abd · 2006-12-05T13:10:17.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@6187 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/plugins/grass/qgsgrasstools.cpp b/src/plugins/grass/qgsgrasstools.cpp
@@ -211,24 +211,27 @@ void QgsGrassTools::moduleClicked( Q3ListViewItem * item )
          // Note: I was not able to run cmd.exe and command.com
          //       with QProcess
 
-         QString msysPath = mAppDir + "/msys/msys.bat";
+         QString msysPath = mAppDir + "/msys/bin/rxvt.exe";
+         QString myArguments = "-backspacekey ^H -sl 2500 -fg white -bg black -sr -fn Courier-16 -tn msys -geometry 80x25 -e    /bin/sh --login -i";
          QFile file ( msysPath );
 
          if ( !file.exists() ) 
          {
-	     QMessageBox::warning( 0, "Warning",
-                 "Cannot find MSYS (" + msysPath + ")" );
+           QMessageBox::warning( 0, "Warning",
+               "Cannot find MSYS (" + msysPath + ")" );
          } 
          else
          {
-             QProcess *proc = new QProcess(this);
-             proc->start (msysPath);
-             proc->waitForStarted();
-             if ( proc->state() != QProcess::Running )
-             {
-	         QMessageBox::warning( 0, "Warning",
+           QProcess *proc = new QProcess(this);
+           //allow msys to exist in a path with spaces
+           msysPath =  "\"" + msysPath + "\""  ;
+           proc->start(msysPath + " " +  myArguments);
+           proc->waitForStarted();
+           if ( proc->state() != QProcess::Running )
+           {
+             QMessageBox::warning( 0, "Warning",
                  "Cannot start MSYS (" + msysPath + ")" );
-             }
+           }
          }
          return;
 #else 
