Skip to content

Commit 23a7bd0

Browse files
committedMay 13, 2017
Introduce QgsReadWriteContext that encapsulates QgsPathResolver
This should make the read/write methods more flexible if we need to give them extra context.
1 parent 15fc16d commit 23a7bd0

File tree

109 files changed

+702
-553
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

109 files changed

+702
-553
lines changed
 

‎doc/api_break.dox

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -920,6 +920,7 @@ QgsDiagramRenderer {#qgis_api_break_3_0_QgsDiagramRenderer}
920920
- xform, fields were no longer required and are removed.
921921
- referencedFields() no longer takes a QgsFields argument.
922922
- renderDiagram() now takes an optional data defined overrides collection argument.
923+
- readXml(), _readXml(), writeXml(), _writeXml() do not take QgsVectorLayer as an argument anymore.
923924

924925

925926
QgsDiagramLayerSettings {#qgis_api_break_3_0_QgsDiagramLayerSettings}
@@ -951,11 +952,13 @@ setting data defined properties instead.
951952
- The renderer member variable was removed, and getRenderer() was renamed to renderer()
952953
- The showAll member variable was removed. setShowAllDiagrams() and showAllDiagrams() should be used instead.
953954
- referencedFields() no longer requires a QgsFields argument.
955+
- readXml() and writeXml() do not take QgsVectorLayer as an argument anymore.
954956

955957
QgsDiagramSettings {#qgis_api_break_3_0_QgsDiagramSettings}
956958
------------------
957959

958960
- The SizeType enum was removed. Use QgsUnitTypes.RenderUnit instead.
961+
- readXml() and writeXml() do not take QgsVectorLayer as an argument anymore.
959962

960963
QgsDial {#qgis_api_break_3_0_QgsDial}
961964
-------
@@ -1280,7 +1283,7 @@ QgsLayerDefinition {#qgis_api_break_3_0_QgsLayerDefinition}
12801283
------------------
12811284

12821285
- loadLayerDefinition() now also requires QgsProject as the second argument
1283-
- loadLayerDefinition() and exportLayerDefinition() variants that take QDomDocument as the first argument now expect QgsPathResolver as the last argument
1286+
- loadLayerDefinition() and exportLayerDefinition() variants that take QDomDocument as the first argument now expect QgsReadWriteContext as the last argument
12841287

12851288

12861289
QgsLayerPropertiesWidget {#qgis_api_break_3_0_QgsLayerPropertiesWidget}
@@ -1413,7 +1416,7 @@ screenUpdateRequested() were removed. These members have had no effect for a num
14131416
- capitaliseLayerName() was renamed to capitalizeLayerName() <!--#spellok-->
14141417
- asLayerDefinition(), fromLayerDefinition(), fromLayerDefinitionFile() were moved to QgsLayerDefinition class and renamed to exportLayerDefinitionLayers() resp. loadLayerDefinitionLayers()
14151418
- loadNamedStyleFromDb() was renamed to loadNamedStyleFromDatabase()
1416-
- readLayerXml() and writeLayerXml() expect QgsPathResolver reference as the last argument
1419+
- readLayerXml() and writeLayerXml() expect QgsReadWriteContext reference as the last argument
14171420
- the invalidTransformInput() slot was removed - calling this slot had no effect
14181421
- metadata() was renamed to htmlMetadata()
14191422

‎python/core/annotations/qgsannotation.sip

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ class QgsAnnotation : QObject
5656

5757
void render( QgsRenderContext &context ) const;
5858

59-
virtual void writeXml( QDomElement &elem, QDomDocument &doc, const QgsPathResolver &pathResolver ) const = 0;
60-
virtual void readXml( const QDomElement &itemElem, const QDomDocument &doc, const QgsPathResolver &pathResolver ) = 0;
59+
virtual void writeXml( QDomElement& elem, QDomDocument & doc, const QgsReadWriteContext &context ) const = 0;
60+
virtual void readXml( const QDomElement& itemElem, const QgsReadWriteContext &context ) = 0;
6161

6262
void setMarkerSymbol( QgsMarkerSymbol *symbol /Transfer/ );
6363
QgsMarkerSymbol *markerSymbol() const;
@@ -80,8 +80,8 @@ class QgsAnnotation : QObject
8080

8181
virtual QSizeF minimumFrameSize() const;
8282

83-
void _writeXml( QDomElement &itemElem, QDomDocument &doc, const QgsPathResolver &pathResolver ) const;
84-
void _readXml( const QDomElement &annotationElem, const QDomDocument &doc, const QgsPathResolver &pathResolver );
83+
void _writeXml( QDomElement& itemElem, QDomDocument& doc, const QgsReadWriteContext &context ) const;
84+
void _readXml( const QDomElement& annotationElem, const QgsReadWriteContext &context );
8585

8686
void copyCommonProperties( QgsAnnotation *target ) const;
8787

0 commit comments

Comments
 (0)
Please sign in to comment.