Add missing references to Q_FOREACH loops

nyalldawson · nyalldawson · commit 239865b70880 · 2016-05-15T20:50:43.000+10:00
diff --git a/src/app/qgsmaptoolshowhidelabels.cpp b/src/app/qgsmaptoolshowhidelabels.cpp
@@ -166,7 +166,7 @@ void QgsMapToolShowHideLabels::showHideLabels( QMouseEvent * e )
     QList<QgsLabelPosition> positions;
     if ( selectedLabelFeatures( vlayer, positions ) )
     {
-      Q_FOREACH ( QgsLabelPosition pos, positions )
+      Q_FOREACH ( const QgsLabelPosition& pos, positions )
       {
         mCurrentLabel.pos = pos;
 
diff --git a/src/core/dxf/qgsdxfexport.cpp b/src/core/dxf/qgsdxfexport.cpp
@@ -3393,7 +3393,7 @@ void QgsDxfExport::writePoint( const QgsPointV2 &pt, const QString& layer, const
 void QgsDxfExport::writePolyline( const QgsPolyline &line, const QString& layer, const QString& lineStyleName, const QColor& color, double width )
 {
   QgsPointSequenceV2 s;
-  Q_FOREACH ( const QgsPoint p, line )
+  Q_FOREACH ( const QgsPoint& p, line )
     s << QgsPointV2( p );
   writePolyline( s, layer, lineStyleName, color, width );
 }
@@ -3468,10 +3468,10 @@ void QgsDxfExport::writePolygon( const QgsPolygon &polygon, const QString& layer
 {
   QgsRingSequenceV2 r;
 
-  Q_FOREACH ( const QgsPolyline l, polygon )
+  Q_FOREACH ( const QgsPolyline& l, polygon )
   {
     QgsPointSequenceV2 s;
-    Q_FOREACH ( const QgsPoint p, l )
+    Q_FOREACH ( const QgsPoint& p, l )
       s << QgsPointV2( p );
     r << s;
   }
diff --git a/src/core/qgsgml.cpp b/src/core/qgsgml.cpp
@@ -180,7 +180,7 @@ int QgsGml::getFeatures( const QByteArray &data, QGis::WkbType* wkbType, QgsRect
 void QgsGml::fillMapsFromParser()
 {
   QVector<QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair> features = mParser.getAndStealReadyFeatures();
-  Q_FOREACH ( QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair featPair, features )
+  Q_FOREACH ( const QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair& featPair, features )
   {
     QgsFeature* feat = featPair.first;
     const QString& gmlId = featPair.second;
diff --git a/src/providers/spatialite/qgsspatialiteprovider.cpp b/src/providers/spatialite/qgsspatialiteprovider.cpp
@@ -451,7 +451,7 @@ QgsSpatiaLiteProvider::QgsSpatiaLiteProvider( QString const &uri )
   if ( mSqliteHandle )
   {
     QStringList pragmaList = anUri.params( "pragma" );
-    Q_FOREACH ( QString pragma, pragmaList )
+    Q_FOREACH ( const QString& pragma, pragmaList )
     {
       char* errMsg = nullptr;
       int ret = sqlite3_exec( mSqliteHandle, ( "PRAGMA " + pragma ).toUtf8(), nullptr, nullptr, &errMsg );
diff --git a/src/providers/virtual/qgsvirtuallayersourceselect.cpp b/src/providers/virtual/qgsvirtuallayersourceselect.cpp
@@ -49,7 +49,7 @@ QgsVirtualLayerSourceSelect::QgsVirtualLayerSourceSelect( QWidget* parent, Qt::W
   QObject::connect( mLayersTable->selectionModel(), SIGNAL( currentRowChanged( const QModelIndex&, const QModelIndex& ) ), this, SLOT( onTableRowChanged( const QModelIndex&, const QModelIndex& ) ) );
 
   // prepare provider list
-  Q_FOREACH ( QString pk, QgsProviderRegistry::instance()->providerList() )
+  Q_FOREACH ( const QString& pk, QgsProviderRegistry::instance()->providerList() )
   {
     // we cannot know before trying to actually load a dataset
     // if the provider is raster or vector
@@ -293,7 +293,7 @@ void QgsVirtualLayerSourceSelect::onImportLayer()
   if ( mEmbeddedSelectionDialog->exec() == QDialog::Accepted )
   {
     QStringList ids = mEmbeddedSelectionDialog->layers();
-    Q_FOREACH ( QString id, ids )
+    Q_FOREACH ( const QString& id, ids )
     {
       QgsVectorLayer *vl = static_cast<QgsVectorLayer*>( QgsMapLayerRegistry::instance()->mapLayer( id ) );
       addEmbeddedLayer( vl->name(), vl->providerType(), vl->dataProvider()->encoding(), vl->source() );
diff --git a/src/providers/wfs/qgswfsutils.cpp b/src/providers/wfs/qgswfsutils.cpp
@@ -116,7 +116,7 @@ bool QgsWFSUtils::removeDir( const QString &dirName )
 {
   QDir dir( dirName );
   QFileInfoList fileList( dir.entryInfoList( QDir::NoDotAndDotDot | QDir::AllDirs | QDir::Files ) );
-  Q_FOREACH ( QFileInfo info, fileList )
+  Q_FOREACH ( const QFileInfo& info, fileList )
   {
     bool result;
     if ( info.isDir() )
@@ -219,7 +219,7 @@ void QgsWFSUtils::init()
   {
     const qint64 currentTimestamp = QDateTime::currentMSecsSinceEpoch();
     QFileInfoList fileList( dir.entryInfoList( QDir::NoDotAndDotDot | QDir::AllDirs | QDir::Files ) );
-    Q_FOREACH ( QFileInfo info, fileList )
+    Q_FOREACH ( const QFileInfo& info, fileList )
     {
       if ( info.isDir() && info.fileName().startsWith( "pid_" ) )
       {

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ void QgsMapToolShowHideLabels::showHideLabels( QMouseEvent * e )`
`166`	`166`	`QList<QgsLabelPosition> positions;`
`167`	`167`	`if ( selectedLabelFeatures( vlayer, positions ) )`
`168`	`168`	`{`
`169`		`- Q_FOREACH ( QgsLabelPosition pos, positions )`
	`169`	`+ Q_FOREACH ( const QgsLabelPosition& pos, positions )`
`170`	`170`	`{`
`171`	`171`	`mCurrentLabel.pos = pos;`
`172`	`172`
Original file line number	Diff line number	Diff line change
`@@ -3393,7 +3393,7 @@ void QgsDxfExport::writePoint( const QgsPointV2 &pt, const QString& layer, const`
`3393`	`3393`	`void QgsDxfExport::writePolyline( const QgsPolyline &line, const QString& layer, const QString& lineStyleName, const QColor& color, double width )`
`3394`	`3394`	`{`
`3395`	`3395`	`QgsPointSequenceV2 s;`
`3396`		`- Q_FOREACH ( const QgsPoint p, line )`
	`3396`	`+ Q_FOREACH ( const QgsPoint& p, line )`
`3397`	`3397`	`s << QgsPointV2( p );`
`3398`	`3398`	`writePolyline( s, layer, lineStyleName, color, width );`
`3399`	`3399`	`}`
`@@ -3468,10 +3468,10 @@ void QgsDxfExport::writePolygon( const QgsPolygon &polygon, const QString& layer`
`3468`	`3468`	`{`
`3469`	`3469`	`QgsRingSequenceV2 r;`
`3470`	`3470`
`3471`		`- Q_FOREACH ( const QgsPolyline l, polygon )`
	`3471`	`+ Q_FOREACH ( const QgsPolyline& l, polygon )`
`3472`	`3472`	`{`
`3473`	`3473`	`QgsPointSequenceV2 s;`
`3474`		`- Q_FOREACH ( const QgsPoint p, l )`
	`3474`	`+ Q_FOREACH ( const QgsPoint& p, l )`
`3475`	`3475`	`s << QgsPointV2( p );`
`3476`	`3476`	`r << s;`
`3477`	`3477`	`}`
Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ int QgsGml::getFeatures( const QByteArray &data, QGis::WkbType* wkbType, QgsRect`
`180`	`180`	`void QgsGml::fillMapsFromParser()`
`181`	`181`	`{`
`182`	`182`	`QVector<QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair> features = mParser.getAndStealReadyFeatures();`
`183`		`- Q_FOREACH ( QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair featPair, features )`
	`183`	`+ Q_FOREACH ( const QgsGmlStreamingParser::QgsGmlFeaturePtrGmlIdPair& featPair, features )`
`184`	`184`	`{`
`185`	`185`	`QgsFeature* feat = featPair.first;`
`186`	`186`	`const QString& gmlId = featPair.second;`
Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ QgsSpatiaLiteProvider::QgsSpatiaLiteProvider( QString const &uri )`
`451`	`451`	`if ( mSqliteHandle )`
`452`	`452`	`{`
`453`	`453`	`QStringList pragmaList = anUri.params( "pragma" );`
`454`		`- Q_FOREACH ( QString pragma, pragmaList )`
	`454`	`+ Q_FOREACH ( const QString& pragma, pragmaList )`
`455`	`455`	`{`
`456`	`456`	`char* errMsg = nullptr;`
`457`	`457`	`int ret = sqlite3_exec( mSqliteHandle, ( "PRAGMA " + pragma ).toUtf8(), nullptr, nullptr, &errMsg );`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ QgsVirtualLayerSourceSelect::QgsVirtualLayerSourceSelect( QWidget* parent, Qt::W`
`49`	`49`	`QObject::connect( mLayersTable->selectionModel(), SIGNAL( currentRowChanged( const QModelIndex&, const QModelIndex& ) ), this, SLOT( onTableRowChanged( const QModelIndex&, const QModelIndex& ) ) );`
`50`	`50`
`51`	`51`	`// prepare provider list`
`52`		`- Q_FOREACH ( QString pk, QgsProviderRegistry::instance()->providerList() )`
	`52`	`+ Q_FOREACH ( const QString& pk, QgsProviderRegistry::instance()->providerList() )`
`53`	`53`	`{`
`54`	`54`	`// we cannot know before trying to actually load a dataset`
`55`	`55`	`// if the provider is raster or vector`
`@@ -293,7 +293,7 @@ void QgsVirtualLayerSourceSelect::onImportLayer()`
`293`	`293`	`if ( mEmbeddedSelectionDialog->exec() == QDialog::Accepted )`
`294`	`294`	`{`
`295`	`295`	`QStringList ids = mEmbeddedSelectionDialog->layers();`
`296`		`- Q_FOREACH ( QString id, ids )`
	`296`	`+ Q_FOREACH ( const QString& id, ids )`
`297`	`297`	`{`
`298`	`298`	`QgsVectorLayer vl = static_cast<QgsVectorLayer>( QgsMapLayerRegistry::instance()->mapLayer( id ) );`
`299`	`299`	`addEmbeddedLayer( vl->name(), vl->providerType(), vl->dataProvider()->encoding(), vl->source() );`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ bool QgsWFSUtils::removeDir( const QString &dirName )`
`116`	`116`	`{`
`117`	`117`	`QDir dir( dirName );`
`118`	`118`	`QFileInfoList fileList( dir.entryInfoList( QDir::NoDotAndDotDot \| QDir::AllDirs \| QDir::Files ) );`
`119`		`- Q_FOREACH ( QFileInfo info, fileList )`
	`119`	`+ Q_FOREACH ( const QFileInfo& info, fileList )`
`120`	`120`	`{`
`121`	`121`	`bool result;`
`122`	`122`	`if ( info.isDir() )`
`@@ -219,7 +219,7 @@ void QgsWFSUtils::init()`
`219`	`219`	`{`
`220`	`220`	`const qint64 currentTimestamp = QDateTime::currentMSecsSinceEpoch();`
`221`	`221`	`QFileInfoList fileList( dir.entryInfoList( QDir::NoDotAndDotDot \| QDir::AllDirs \| QDir::Files ) );`
`222`		`- Q_FOREACH ( QFileInfo info, fileList )`
	`222`	`+ Q_FOREACH ( const QFileInfo& info, fileList )`
`223`	`223`	`{`
`224`	`224`	`if ( info.isDir() && info.fileName().startsWith( "pid_" ) )`
`225`	`225`	`{`