Skip to content

Commit 231f6af

Browse files
committedJan 14, 2017
Don't return const references to implicitly shared Qt classes
Instead return the inexpensive copies. Should provide extra safety against issues like #14822 (refs #14822)
1 parent ef8a135 commit 231f6af

File tree

97 files changed

+172
-222
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

97 files changed

+172
-222
lines changed
 

‎python/analysis/raster/qgsrelief.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class QgsRelief
2626

2727
void clearReliefColors();
2828
void addReliefColorClass( const QgsRelief::ReliefColor& color );
29-
const QList< QgsRelief::ReliefColor >& reliefColors() const;
29+
QList< QgsRelief::ReliefColor > reliefColors() const;
3030
void setReliefColors( const QList< QgsRelief::ReliefColor >& c );
3131

3232
/** Calculates class breaks according with the method of Buenzli (2011) using an iterative algorithm for segmented regression

‎python/core/composer/qgsatlascomposition.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public:
145145
* @see setPredefinedScales
146146
* @see QgsComposerMap::atlasScalingMode
147147
*/
148-
const QVector<qreal>& predefinedScales() const;
148+
QVector<qreal> predefinedScales() const;
149149

150150
/** Sets the list of predefined scales for the atlas. This is used
151151
* for maps which are set to the predefined atlas scaling mode.

0 commit comments

Comments
 (0)
Please sign in to comment.