Fix missing copy in QgsSQLStatement copy constructor

nyalldawson · nyalldawson · commit 22dda853425f · 2023-04-17T16:01:29.000+10:00
No real bug here -- the value is unused outside of the constructor
diff --git a/src/core/qgssqlstatement.cpp b/src/core/qgssqlstatement.cpp
@@ -141,9 +141,10 @@ QgsSQLStatement::QgsSQLStatement( const QString &expr, bool allowFragments )
 }
 
 QgsSQLStatement::QgsSQLStatement( const QgsSQLStatement &other )
+  : mAllowFragments( other.mAllowFragments )
+  , mStatement( other.mStatement )
 {
-  mRootNode = ::parse( other.mStatement, mParserErrorString, other.mAllowFragments );
-  mStatement = other.mStatement;
+  mRootNode = ::parse( mStatement, mParserErrorString, mAllowFragments );
 }
 
 QgsSQLStatement &QgsSQLStatement::operator=( const QgsSQLStatement &other )

Original file line number	Diff line number	Diff line change
`@@ -141,9 +141,10 @@ QgsSQLStatement::QgsSQLStatement( const QString &expr, bool allowFragments )`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`QgsSQLStatement::QgsSQLStatement( const QgsSQLStatement &other )`
	`144`	`+ : mAllowFragments( other.mAllowFragments )`
	`145`	`+ , mStatement( other.mStatement )`
`144`	`146`	`{`
`145`		`- mRootNode = ::parse( other.mStatement, mParserErrorString, other.mAllowFragments );`
`146`		`- mStatement = other.mStatement;`
	`147`	`+ mRootNode = ::parse( mStatement, mParserErrorString, mAllowFragments );`
`147`	`148`	`}`
`148`	`149`
`149`	`150`	`QgsSQLStatement &QgsSQLStatement::operator=( const QgsSQLStatement &other )`