Only emit QgsCollapsibleGroupBoxBasic::collapsedStateChanged when state really has changed

manisandro · nyalldawson · commit 221c4e0468d3 · 2016-06-07T07:26:34.000+10:00
diff --git a/src/gui/qgscollapsiblegroupbox.cpp b/src/gui/qgscollapsiblegroupbox.cpp
@@ -402,6 +402,7 @@ void QgsCollapsibleGroupBoxBasic::updateStyle()
 
 void QgsCollapsibleGroupBoxBasic::setCollapsed( bool collapse )
 {
+  bool changed = collapse != mCollapsed;
   mCollapsed = collapse;
 
   if ( !isVisible() )
@@ -438,7 +439,8 @@ void QgsCollapsibleGroupBoxBasic::setCollapsed( bool collapse )
     mParentScrollArea->setUpdatesEnabled( true );
   }
   // emit signal for connections using collapsed state
-  emit collapsedStateChanged( isCollapsed() );
+  if ( changed )
+    emit collapsedStateChanged( isCollapsed() );
 }
 
 void QgsCollapsibleGroupBoxBasic::collapseExpandFixes()

Original file line number	Diff line number	Diff line change
`@@ -402,6 +402,7 @@ void QgsCollapsibleGroupBoxBasic::updateStyle()`
`402`	`402`
`403`	`403`	`void QgsCollapsibleGroupBoxBasic::setCollapsed( bool collapse )`
`404`	`404`	`{`
	`405`	`+ bool changed = collapse != mCollapsed;`
`405`	`406`	`mCollapsed = collapse;`
`406`	`407`
`407`	`408`	`if ( !isVisible() )`
`@@ -438,7 +439,8 @@ void QgsCollapsibleGroupBoxBasic::setCollapsed( bool collapse )`
`438`	`439`	`mParentScrollArea->setUpdatesEnabled( true );`
`439`	`440`	`}`
`440`	`441`	`// emit signal for connections using collapsed state`
`441`		`- emit collapsedStateChanged( isCollapsed() );`
	`442`	`+ if ( changed )`
	`443`	`+ emit collapsedStateChanged( isCollapsed() );`
`442`	`444`	`}`
`443`	`445`
`444`	`446`	`void QgsCollapsibleGroupBoxBasic::collapseExpandFixes()`