Avoid gps toolbar changing size too regularly by restricting when

nyalldawson · nyalldawson · commit 210860bf45ac · 2023-01-11T18:00:05.000+10:00
the information label is allowed to shrink in size
diff --git a/src/app/gps/qgsgpstoolbar.cpp b/src/app/gps/qgsgpstoolbar.cpp
@@ -301,6 +301,33 @@ void QgsGpsToolBar::updateLocationLabel()
     }
 
     mInformationButton->setText( parts.join( ' ' ) );
+
+    //ensure the label is big (and small) enough
+    const int width = mInformationButton->fontMetrics().boundingRect( mInformationButton->text() ).width() + 16;
+    bool allowResize = false;
+    if ( mIsFirstSizeChange )
+    {
+      allowResize = true;
+    }
+    else if ( mInformationButton->minimumWidth() < width )
+    {
+      // always immediately grow to fit
+      allowResize = true;
+    }
+    else if ( ( mInformationButton->minimumWidth() - width ) > mInformationButton->fontMetrics().averageCharWidth() * 2 )
+    {
+      // only allow shrinking when a sufficient time has expired since we last resized.
+      // this avoids extraneous shrinking/growing resulting in distracting UI changes
+      allowResize = mLastLabelSizeChangeTimer.hasExpired( 5000 );
+    }
+
+    if ( allowResize )
+    {
+      mInformationButton->setMinimumWidth( width );
+      mInformationButton->setMaximumWidth( width );
+      mLastLabelSizeChangeTimer.restart();
+      mIsFirstSizeChange = false;
+    }
   }
 
   adjustSize();
diff --git a/src/app/gps/qgsgpstoolbar.h b/src/app/gps/qgsgpstoolbar.h
@@ -18,6 +18,7 @@
 
 #include <QToolBar>
 #include <QPointer>
+#include <QElapsedTimer>
 
 #include "qgscoordinatereferencesystem.h"
 #include "qgssettingsentryenumflag.h"
@@ -89,6 +90,9 @@ class QgsGpsToolBar : public QToolBar
     bool mEnableAddVertexButton = true;
 
     QgsMapLayerProxyModel *mDestinationLayerModel = nullptr;
+
+    bool mIsFirstSizeChange = true;
+    QElapsedTimer mLastLabelSizeChangeTimer;
 };
 
 #endif // QGSGPSTOOLBAR_H
