[Geometry checker] Fix memory corruption in QgsGeometryTypeCheck fix when converting to singleparts

manisandro · manisandro · commit 20658509dc5b · 2016-01-19T09:39:29.000+01:00
diff --git a/src/plugins/geometry_checker/checks/qgsgeometrytypecheck.cpp b/src/plugins/geometry_checker/checks/qgsgeometrytypecheck.cpp
@@ -74,7 +74,8 @@ void QgsGeometryTypeCheck::fixError( QgsGeometryCheckError* error, int method, i
         changes[newFeature.id()].append( Change( ChangeFeature, ChangeAdded ) );
       }
       // Recycle feature for part 0
-      feature.setGeometry( new QgsGeometry( QgsGeomUtils::getGeomPart( geom, 0 ) ) );
+      feature.setGeometry( new QgsGeometry( QgsGeomUtils::getGeomPart( geom, 0 )->clone() ) );
+      mFeaturePool->updateFeature( feature );
       changes[feature.id()].append( Change( ChangeFeature, ChangeChanged ) );
     }
     // Check if corresponding multi type is allowed

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,8 @@ void QgsGeometryTypeCheck::fixError( QgsGeometryCheckError* error, int method, i`
`74`	`74`	`changes[newFeature.id()].append( Change( ChangeFeature, ChangeAdded ) );`
`75`	`75`	`}`
`76`	`76`	`// Recycle feature for part 0`
`77`		`- feature.setGeometry( new QgsGeometry( QgsGeomUtils::getGeomPart( geom, 0 ) ) );`
	`77`	`+ feature.setGeometry( new QgsGeometry( QgsGeomUtils::getGeomPart( geom, 0 )->clone() ) );`
	`78`	`+ mFeaturePool->updateFeature( feature );`
`78`	`79`	`changes[feature.id()].append( Change( ChangeFeature, ChangeChanged ) );`
`79`	`80`	`}`
`80`	`81`	`// Check if corresponding multi type is allowed`