Random Points on Lines algorithm: Fix check minimum distance logic (#35713)

havatv · nyalldawson · commit 202284849279 · 2020-04-12T09:04:10.000+10:00
diff --git a/src/analysis/processing/qgsalgorithmrandompointsonlines.cpp b/src/analysis/processing/qgsalgorithmrandompointsonlines.cpp
@@ -273,7 +273,7 @@ QVariantMap QgsRandomPointsOnLinesAlgorithm::processAlgorithm( const QVariantMap
 
         if ( !rpGeom.isNull() && !rpGeom.isEmpty() )
         {
-          if ( minDistanceForThisFeature != 0 && pointsAddedForThisFeature > 0 )
+          if ( minDistanceForThisFeature != 0 && totNPoints > 0 )
           {
             // Have to check minimum distance to existing points
             QList<QgsFeatureId> neighbors = index.nearestNeighbor( rpGeom, 1, minDistanceForThisFeature );

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ QVariantMap QgsRandomPointsOnLinesAlgorithm::processAlgorithm( const QVariantMap`
`273`	`273`
`274`	`274`	`if ( !rpGeom.isNull() && !rpGeom.isEmpty() )`
`275`	`275`	`{`
`276`		`- if ( minDistanceForThisFeature != 0 && pointsAddedForThisFeature > 0 )`
	`276`	`+ if ( minDistanceForThisFeature != 0 && totNPoints > 0 )`
`277`	`277`	`{`
`278`	`278`	`// Have to check minimum distance to existing points`
`279`	`279`	`QList<QgsFeatureId> neighbors = index.nearestNeighbor( rpGeom, 1, minDistanceForThisFeature );`