Fixes after review

qgis · Dec 5, 2017 · 1f6cd31 · 1f6cd31
1 parent b773d61
commit 1f6cd31
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/3d/qgs3dutils.cpp b/src/3d/qgs3dutils.cpp
@@ -90,8 +90,8 @@ QString Qgs3DUtils::cullingModeToString( Qt3DRender::QCullFace::CullingMode mode
     case Qt3DRender::QCullFace::Front: return QStringLiteral( "front" );
     case Qt3DRender::QCullFace::Back: return QStringLiteral( "back" );
     case Qt3DRender::QCullFace::FrontAndBack: return QStringLiteral( "front-and-back" );
-    default: return QString();
   }
+  return QString();
 }
 
 Qt3DRender::QCullFace::CullingMode Qgs3DUtils::cullingModeFromString( const QString &str )

diff --git a/src/3d/qgstessellator.cpp b/src/3d/qgstessellator.cpp
@@ -420,7 +420,7 @@ void QgsTessellator::addPolygon( const QgsPolygon &polygon, float extrusionHeigh
       polylinesToDelete << holePolyline;
     }
 
-    // run triangulation and write vertices to the ouput data array
+    // run triangulation and write vertices to the output data array
     try
     {
       cdt->Triangulate();

diff --git a/src/3d/symbols/qgspolygon3dsymbol_p.cpp b/src/3d/symbols/qgspolygon3dsymbol_p.cpp
@@ -113,7 +113,7 @@ Qt3DExtras::QPhongMaterial *QgsPolygon3DSymbolEntity::material( const QgsPolygon
 
   // front/back side culling
   auto techniques = material->effect()->techniques();
-  for ( auto tit = techniques.begin(); tit != techniques.end(); ++tit )
+  for ( auto tit = techniques.constBegin(); tit != techniques.constEnd(); ++tit )
   {
     auto renderPasses = ( *tit )->renderPasses();
     for ( auto rpit = renderPasses.begin(); rpit != renderPasses.end(); ++rpit )