Skip to content

Commit 1eaf03d

Browse files
committedMay 12, 2017
Speed up the check for valid feature
1 parent db89929 commit 1eaf03d

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed
 

‎src/gui/attributetable/qgsattributetabledelegate.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,12 @@ void QgsAttributeTableDelegate::setModelData( QWidget *editor, QAbstractItemMode
9494
return;
9595

9696
// This fixes https://issues.qgis.org/issues/16492
97-
if ( ! vl->getFeature( fid ).isValid( ) )
97+
QgsFeatureRequest request( fid );
98+
request.setFlags( QgsFeatureRequest::NoGeometry );
99+
request.setSubsetOfAttributes( QgsAttributeList( ) );
100+
QgsFeature feature;
101+
vl->getFeatures( request ).nextFeature( feature );
102+
if ( ! feature.isValid( ) )
98103
{
99104
// Model is out of sync (again!).
100105
return;

0 commit comments

Comments
 (0)
Please sign in to comment.