Minor code improvements

qgis · Jul 14, 2017 · 1e145b3 · 1e145b3
1 parent 4c432a1
commit 1e145b3
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/gui/qgsmapcanvas.cpp b/src/gui/qgsmapcanvas.cpp
@@ -639,10 +639,7 @@ void QgsMapCanvas::rendererJobFinished()
 void QgsMapCanvas::previewJobFinished()
 {
   QgsMapRendererQImageJob *job = qobject_cast<QgsMapRendererQImageJob *>( sender() );
-  if ( !job )
-  {
-    return;
-  }
+  Q_ASSERT( job );
 
   if ( mMap )
   {
@@ -2166,8 +2163,8 @@ void QgsMapCanvas::startPreviewJobs()
 
 void QgsMapCanvas::stopPreviewJobs()
 {
-  QList< QgsMapRendererQImageJob * >::iterator it = mPreviewJobs.begin();
-  for ( ; it != mPreviewJobs.end(); ++it )
+  QList< QgsMapRendererQImageJob * >::const_iterator it = mPreviewJobs.constBegin();
+  for ( ; it != mPreviewJobs.constEnd(); ++it )
   {
     if ( *it )
     {