[win] Fix some warnings

qgis · Sep 17, 2018 · 1d8dbda · 1d8dbda
1 parent a0dceb1
commit 1d8dbda
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/external/wintoast/src/wintoastlib.h b/external/wintoast/src/wintoastlib.h
@@ -35,6 +35,7 @@ namespace WinToastLib {
             ApplicationHidden = ToastDismissalReason::ToastDismissalReason_ApplicationHidden,
             TimedOut = ToastDismissalReason::ToastDismissalReason_TimedOut
         };
+        virtual ~IWinToastHandler() = default;
         virtual void toastActivated() const = 0;
         virtual void toastActivated(int actionIndex) const = 0;
         virtual void toastDismissed(WinToastDismissalReason state) const = 0;

diff --git a/src/native/win/qgswinnative.cpp b/src/native/win/qgswinnative.cpp
@@ -70,7 +70,7 @@ void QgsWinNative::openFileExplorerAndSelectFile( const QString &path )
   const QString nativePath = QDir::toNativeSeparators( path );
 
   wchar_t *pathArray = new wchar_t[static_cast< uint>( nativePath.length() + 1 )];
-  nativePath.toWCharArray(pathArray);
+  nativePath.toWCharArray( pathArray );
   pathArray[nativePath.length()] = 0;
 
   ITEMIDLIST *pidl = ILCreateFromPathW( pathArray );
@@ -124,7 +124,7 @@ class NotificationHandler : public WinToastLib::IWinToastHandler
 
     void toastActivated( int ) const override {}
 
-    void toastFailed() const
+    void toastFailed() const override
     {
       qWarning() << "Error showing notification";
     }

diff --git a/tests/src/python/test_qgsprocessinginplace.py b/tests/src/python/test_qgsprocessinginplace.py
@@ -26,6 +26,7 @@
 
 
 class ConsoleFeedBack(QgsProcessingFeedback):
+
     def reportError(self, error, fatalError=False):
         print(error)