Fix random color ramps returning invalid QColors for value of 1.0

nyalldawson · nyalldawson · commit 1d2b4cb41aa8 · 2015-08-04T16:22:49.000+10:00
diff --git a/src/core/symbology-ng/qgsvectorcolorrampv2.cpp b/src/core/symbology-ng/qgsvectorcolorrampv2.cpp
@@ -297,7 +297,7 @@ double QgsVectorRandomColorRampV2::value( int index ) const
 QColor QgsVectorRandomColorRampV2::color( double value ) const
 {
   int colorCnt = mColors.count();
-  int colorIdx = ( int )( value * colorCnt );
+  int colorIdx = ( int )( value * ( colorCnt - 1 ) );
 
   if ( colorIdx >= 0 && colorIdx < colorCnt )
     return mColors.at( colorIdx );

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ double QgsVectorRandomColorRampV2::value( int index ) const`
`297`	`297`	`QColor QgsVectorRandomColorRampV2::color( double value ) const`
`298`	`298`	`{`
`299`	`299`	`int colorCnt = mColors.count();`
`300`		`- int colorIdx = ( int )( value * colorCnt );`
	`300`	`+ int colorIdx = ( int )( value * ( colorCnt - 1 ) );`
`301`	`301`
`302`	`302`	`if ( colorIdx >= 0 && colorIdx < colorCnt )`
`303`	`303`	`return mColors.at( colorIdx );`