Hide import/export buttons for arcgis services as they do not work (fixes #15637)

wonder-sk · wonder-sk · commit 1c2f0de9fbea · 2016-10-21T11:19:32.000+08:00
diff --git a/src/gui/qgssourceselectdialog.cpp b/src/gui/qgssourceselectdialog.cpp
@@ -413,27 +413,6 @@ void QgsSourceSelectDialog::on_cmbConnections_activated( int index )
   QgsOWSConnection::setSelectedConnection( mServiceName, cmbConnections->currentText() );
 }
 
-void QgsSourceSelectDialog::on_btnSave_clicked()
-{
-  QgsManageConnectionsDialog dlg( this, QgsManageConnectionsDialog::Export, QgsManageConnectionsDialog::WFS );
-  dlg.exec();
-}
-
-void QgsSourceSelectDialog::on_btnLoad_clicked()
-{
-  QString fileName = QFileDialog::getOpenFileName( this, tr( "Load connections" ), ".",
-                     tr( "XML files (*.xml *XML)" ) );
-  if ( fileName.isEmpty() )
-  {
-    return;
-  }
-
-  QgsManageConnectionsDialog dlg( this, QgsManageConnectionsDialog::Import, QgsManageConnectionsDialog::WFS, fileName );
-  dlg.exec();
-  populateConnectionList();
-  emit connectionsChanged();
-}
-
 void QgsSourceSelectDialog::treeWidgetItemDoubleClicked( const QModelIndex& index )
 {
   QgsDebugMsg( "double click called" );
diff --git a/src/gui/qgssourceselectdialog.h b/src/gui/qgssourceselectdialog.h
@@ -99,8 +99,6 @@ class GUI_EXPORT QgsSourceSelectDialog : public QDialog, protected Ui::QgsSource
     void changeCRSFilter();
     void connectToServer();
     void filterChanged( QString text );
-    void on_btnLoad_clicked();
-    void on_btnSave_clicked();
     void on_cmbConnections_activated( int index );
     void on_buttonBox_helpRequested() const;
     void treeWidgetItemDoubleClicked( const QModelIndex & index );
diff --git a/src/providers/arcgisrest/qgsafssourceselect.cpp b/src/providers/arcgisrest/qgsafssourceselect.cpp
@@ -32,6 +32,10 @@ QgsAfsSourceSelect::QgsAfsSourceSelect( QWidget* parent, Qt::WindowFlags fl, boo
   {
     buttonBox->button( QDialogButtonBox::Close )->hide();
   }
+
+  // import/export of connections not supported yet
+  btnLoad->hide();
+  btnSave->hide();
 }
 
 bool QgsAfsSourceSelect::connectToService( const QgsOWSConnection &connection )
diff --git a/src/providers/arcgisrest/qgsamssourceselect.cpp b/src/providers/arcgisrest/qgsamssourceselect.cpp
@@ -32,6 +32,10 @@ QgsAmsSourceSelect::QgsAmsSourceSelect( QWidget* parent, Qt::WindowFlags fl, boo
   {
     buttonBox->button( QDialogButtonBox::Close )->hide();
   }
+
+  // import/export of connections not supported yet
+  btnLoad->hide();
+  btnSave->hide();
 }
 
 bool QgsAmsSourceSelect::connectToService( const QgsOWSConnection &connection )

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ QgsAfsSourceSelect::QgsAfsSourceSelect( QWidget* parent, Qt::WindowFlags fl, boo`
`32`	`32`	`{`
`33`	`33`	`buttonBox->button( QDialogButtonBox::Close )->hide();`
`34`	`34`	`}`
	`35`	`+`
	`36`	`+ // import/export of connections not supported yet`
	`37`	`+ btnLoad->hide();`
	`38`	`+ btnSave->hide();`
`35`	`39`	`}`
`36`	`40`
`37`	`41`	`bool QgsAfsSourceSelect::connectToService( const QgsOWSConnection &connection )`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ QgsAmsSourceSelect::QgsAmsSourceSelect( QWidget* parent, Qt::WindowFlags fl, boo`
`32`	`32`	`{`
`33`	`33`	`buttonBox->button( QDialogButtonBox::Close )->hide();`
`34`	`34`	`}`
	`35`	`+`
	`36`	`+ // import/export of connections not supported yet`
	`37`	`+ btnLoad->hide();`
	`38`	`+ btnSave->hide();`
`35`	`39`	`}`
`36`	`40`
`37`	`41`	`bool QgsAmsSourceSelect::connectToService( const QgsOWSConnection &connection )`