Skip to content

Commit 1c225b7

Browse files
committedOct 6, 2016
Fix rule based renderer shows 0 count on first click of "show counts"
(cherry-picked from 291f7bd)
1 parent 550716a commit 1c225b7

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed
 

‎src/gui/symbology-ng/qgsrulebasedrendererv2widget.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,6 @@ void QgsRuleBasedRendererV2Widget::countFeatures()
517517
countMap[rule].duplicateCount = 0;
518518
}
519519

520-
QgsFeatureRequest req = QgsFeatureRequest().setFilterExpression( mRenderer->filter( mLayer->fields() ) );
521-
522520
QgsRenderContext renderContext;
523521
renderContext.setRendererScale( 0 ); // ignore scale
524522

@@ -538,10 +536,11 @@ void QgsRuleBasedRendererV2Widget::countFeatures()
538536
context << QgsExpressionContextUtils::layerScope( mLayer );
539537

540538
renderContext.setExpressionContext( context );
541-
req.setExpressionContext( context );
542539

543540
mRenderer->startRender( renderContext, mLayer->fields() );
544-
541+
// QgsRuleBasedRenderer::filter must be called after startRender
542+
QgsFeatureRequest req = QgsFeatureRequest().setFilterExpression( mRenderer->filter( mLayer->fields() ) );
543+
req.setExpressionContext( context );
545544
req.setSubsetOfAttributes( mRenderer->usedAttributes(), mLayer->fields() );
546545
QgsFeatureIterator fit = mLayer->getFeatures( req );
547546

0 commit comments

Comments
 (0)
Please sign in to comment.