add QStringLiteral

qgis · Sep 30, 2021 · 1c0e85f · 1c0e85f
1 parent 89fa824
commit 1c0e85f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/core/qgsfield.cpp b/src/core/qgsfield.cpp
@@ -344,13 +344,12 @@ QString QgsField::displayString( const QVariant &v ) const
   }
   else if ( d->type == QVariant::StringList || d->type == QVariant::List )
   {
-    // we return an empty string if the list is empty, not a null string
-    QString result( "" );
+    QString result;
     const QVariantList list = v.toList();
     for ( const QVariant &var : list )
     {
       if ( !result.isEmpty() )
-        result.append( ", " );
+        result.append( QStringLiteral( ", " ) );
       result.append( var.toString() );
     }
     return result;

diff --git a/src/gui/qgsexpressionbuilderwidget.cpp b/src/gui/qgsexpressionbuilderwidget.cpp
@@ -550,11 +550,11 @@ void QgsExpressionBuilderWidget::fillFieldValues( const QString &fieldName, int
       for ( QString str : strList )
       {
         if ( !result.isEmpty() )
-          result.append( ", " );
+          result.append( QStringLiteral( ", " ) );
 
         result.append( '\'' + str.replace( '\'', QLatin1String( "''" ) ) + '\'' );
       }
-      strValue = QString( "array(%1)" ).arg( result );
+      strValue = QStringLiteral( "array(%1)" ).arg( result );
       forceRepresentedValue = true;
     }
     else