Ctrl zoom (#3154)

nyalldawson · NathanW2 · commit 1b2af79c9657 · 2016-06-01T07:43:52.000+10:00
* Switch QgsMapCanvas zoomIn and zoomOut to slots * Change shortcuts to zoom in/out tool to Ctrl+Alt +/-, and make Ctrl + and Ctrl - trigger an immediate zoom in/out Having Ctrl +/- perform an immediate zoom in/out is standard across almost all apps with a zoom facility, so we should respect that same behaviour. This change also helps bring canvas and composer behaviour closer together. (fix #1824)
diff --git a/python/gui/qgsmapcanvas.sip b/python/gui/qgsmapcanvas.sip
@@ -279,12 +279,6 @@ class QgsMapCanvas : QGraphicsView
     //! set the wheel zoom factor
     void setWheelFactor( double factor );
 
-    //! Zoom in with fixed factor
-    void zoomIn();
-
-    //! Zoom out with fixed factor
-    void zoomOut();
-
     //! Zoom to a specific scale
     void zoomScale( double scale );
 
@@ -466,6 +460,12 @@ class QgsMapCanvas : QGraphicsView
     //! @see scaleLocked()
     void setScaleLocked( bool isLocked );
 
+    //! Zoom in with fixed factor
+    void zoomIn();
+
+    //! Zoom out with fixed factor
+    void zoomOut();
+
   signals:
     /** Let the owner know how far we are with render operations */
     //! @deprecated since 2.4 - already unused in 2.0 anyway
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -54,6 +54,7 @@
 #include <QRegExp>
 #include <QRegExpValidator>
 #include <QSettings>
+#include <QShortcut>
 #include <QSpinBox>
 #include <QSplashScreen>
 #ifndef QT_NO_OPENSSL
@@ -935,6 +936,14 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
   mMapCanvas->clearExtentHistory(); // reset zoomnext/zoomlast
   mLastComposerId = 0;
 
+  QAction* zoomAction = new QAction( this );
+  connect( zoomAction, SIGNAL( triggered( bool ) ), mMapCanvas, SLOT( zoomIn() ) );
+  zoomAction->setShortcut( QKeySequence( "Ctrl++" ) );
+  QShortcut* zoomShortCut = new QShortcut( QKeySequence( tr( "Ctrl+=" ) ), this );
+  connect( zoomShortCut, SIGNAL( activated() ), mMapCanvas, SLOT( zoomIn() ) );
+  QAction* zoomOutAction = new QAction( this );
+  connect( zoomOutAction, SIGNAL( triggered( bool ) ), mMapCanvas, SLOT( zoomOut() ) );
+  zoomOutAction->setShortcut( QKeySequence( "Ctrl+-" ) );
 
   // Show a nice tip of the day
   if ( settings.value( QString( "/qgis/showTips%1" ).arg( QGis::QGIS_VERSION_INT / 100 ), true ).toBool() )
diff --git a/src/gui/qgsmapcanvas.h b/src/gui/qgsmapcanvas.h
@@ -350,12 +350,6 @@ class GUI_EXPORT QgsMapCanvas : public QGraphicsView
     //! set wheel zoom factor (should be greater than 1)
     void setWheelFactor( double factor );
 
-    //! Zoom in with fixed factor
-    void zoomIn();
-
-    //! Zoom out with fixed factor
-    void zoomOut();
-
     //! Zoom to a specific scale
     void zoomScale( double scale );
 
@@ -537,6 +531,12 @@ class GUI_EXPORT QgsMapCanvas : public QGraphicsView
     //! @see scaleLocked()
     void setScaleLocked( bool isLocked );
 
+    //! Zoom in with fixed factor
+    void zoomIn();
+
+    //! Zoom out with fixed factor
+    void zoomOut();
+
   private slots:
     //! called when current maptool is destroyed
     void mapToolDestroyed();
diff --git a/src/ui/qgisapp.ui b/src/ui/qgisapp.ui
@@ -933,7 +933,7 @@
     <string>Zoom In</string>
    </property>
    <property name="shortcut">
-    <string>Ctrl++</string>
+    <string>Ctrl+Alt++</string>
    </property>
   </action>
   <action name="mActionZoomOut">
@@ -948,7 +948,7 @@
     <string>Zoom Out</string>
    </property>
    <property name="shortcut">
-    <string>Ctrl+-</string>
+    <string>Ctrl+Alt+-</string>
    </property>
   </action>
   <action name="mActionSelectFeatures">
