Fix some map edit tools don't use correct rubberband color

nyalldawson · nyalldawson · commit 1ac5ca02c724 · 2018-07-12T11:41:09.000+10:00
Fixes #19381
diff --git a/src/app/qgsmaptoolmovefeature.cpp b/src/app/qgsmaptoolmovefeature.cpp
@@ -163,8 +163,6 @@ void QgsMapToolMoveFeature::cadCanvasReleaseEvent( QgsMapMouseEvent *e )
     }
 
     mStartPointMapCoords = e->mapPoint();
-    mRubberBand->setColor( QColor( 255, 0, 0, 65 ) );
-    mRubberBand->setWidth( 2 );
     mRubberBand->show();
   }
   else
diff --git a/src/app/qgsmaptoolrotatefeature.cpp b/src/app/qgsmaptoolrotatefeature.cpp
@@ -299,8 +299,6 @@ void QgsMapToolRotateFeature::canvasReleaseEvent( QgsMapMouseEvent *e )
       }
     }
 
-    mRubberBand->setColor( QColor( 255, 0, 0, 65 ) );
-    mRubberBand->setWidth( 2 );
     mRubberBand->show();
 
     double XDistance = mInitialPos.x() - mAnchorPoint->x();
diff --git a/src/app/qgsmaptoolsimplify.cpp b/src/app/qgsmaptoolsimplify.cpp
@@ -399,9 +399,7 @@ void QgsMapToolSimplify::canvasReleaseEvent( QgsMapMouseEvent *e )
     if ( f.hasGeometry() )
       mOriginalVertexCount += f.geometry().constGet()->nCoordinates();
 
-    QgsRubberBand *rb = new QgsRubberBand( mCanvas );
-    rb->setColor( QColor( 255, 0, 0, 65 ) );
-    rb->setWidth( 2 );
+    QgsRubberBand *rb = createRubberBand();
     rb->show();
     mRubberBands << rb;
   }

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,6 @@ void QgsMapToolMoveFeature::cadCanvasReleaseEvent( QgsMapMouseEvent *e )`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`mStartPointMapCoords = e->mapPoint();`
`166`		`- mRubberBand->setColor( QColor( 255, 0, 0, 65 ) );`
`167`		`- mRubberBand->setWidth( 2 );`
`168`	`166`	`mRubberBand->show();`
`169`	`167`	`}`
`170`	`168`	`else`
Original file line number	Diff line number	Diff line change
`@@ -299,8 +299,6 @@ void QgsMapToolRotateFeature::canvasReleaseEvent( QgsMapMouseEvent *e )`
`299`	`299`	`}`
`300`	`300`	`}`
`301`	`301`
`302`		`- mRubberBand->setColor( QColor( 255, 0, 0, 65 ) );`
`303`		`- mRubberBand->setWidth( 2 );`
`304`	`302`	`mRubberBand->show();`
`305`	`303`
`306`	`304`	`double XDistance = mInitialPos.x() - mAnchorPoint->x();`