Ensure FILTER_GEOM is transformed to layer CRS in GetFeatureInfo

manisandro · manisandro · commit 184480bcd67d · 2018-03-06T13:16:36.000+01:00
diff --git a/src/server/services/wms/qgswmsrenderer.cpp b/src/server/services/wms/qgswmsrenderer.cpp
@@ -1358,6 +1358,16 @@ namespace QgsWms
       return false;
     }
 
+    QgsFeatureRequest fReq;
+
+    // Transform filter geometry to layer CRS
+    std::unique_ptr<QgsGeometry> layerFilterGeom;
+    if ( filterGeom )
+    {
+      layerFilterGeom.reset( new QgsGeometry( *filterGeom ) );
+      layerFilterGeom->transform( QgsCoordinateTransform( mapSettings.destinationCrs(), layer->crs(), fReq.transformContext() ) );
+    }
+
     //we need a selection rect (0.01 of map width)
     QgsRectangle mapRect = mapSettings.extent();
     QgsRectangle layerRect = mapSettings.mapToLayerCoordinates( layer, mapRect );
@@ -1370,9 +1380,9 @@ namespace QgsWms
     {
       searchRect = featureInfoSearchRect( layer, mapSettings, renderContext, *infoPoint );
     }
-    else if ( filterGeom )
+    else if ( layerFilterGeom )
     {
-      searchRect = filterGeom->boundingBox();
+      searchRect = layerFilterGeom->boundingBox();
     }
     else if ( mParameters.contains( QStringLiteral( "BBOX" ) ) )
     {
@@ -1390,8 +1400,7 @@ namespace QgsWms
     bool segmentizeWktGeometry = QgsServerProjectUtils::wmsFeatureInfoSegmentizeWktGeometry( *mProject );
     const QSet<QString> &excludedAttributes = layer->excludeAttributesWms();
 
-    QgsFeatureRequest fReq;
-    bool hasGeometry = addWktGeometry || featureBBox || filterGeom;
+    bool hasGeometry = addWktGeometry || featureBBox || layerFilterGeom;
     fReq.setFlags( ( ( hasGeometry ) ? QgsFeatureRequest::NoFlags : QgsFeatureRequest::NoGeometry ) | QgsFeatureRequest::ExactIntersect );
 
     if ( ! searchRect.isEmpty() )
@@ -1403,9 +1412,10 @@ namespace QgsWms
       fReq.setFlags( fReq.flags() & ~ QgsFeatureRequest::ExactIntersect );
     }
 
-    if ( filterGeom )
+
+    if ( layerFilterGeom )
     {
-      fReq.setFilterExpression( QString( "intersects( $geometry, geom_from_wkt('%1') )" ).arg( filterGeom->asWkt() ) );
+      fReq.setFilterExpression( QString( "intersects( $geometry, geom_from_wkt('%1') )" ).arg( layerFilterGeom->asWkt() ) );
     }
 
 #ifdef HAVE_SERVER_PYTHON_PLUGINS
diff --git a/tests/src/python/test_qgsserver_wms.py b/tests/src/python/test_qgsserver_wms.py
@@ -193,11 +193,20 @@ def test_getfeatureinfo(self):
         self.wms_request_compare('GetFeatureInfo',
                                  '&layers=testlayer%20%C3%A8%C3%A9&' +
                                  'INFO_FORMAT=text%2Fxml&' +
-                                 'width=600&height=400&srs=EPSG%3A3857&' +
+                                 'width=600&height=400&srs=EPSG%3A4326&' +
                                  'query_layers=testlayer%20%C3%A8%C3%A9&' +
                                  'FEATURE_COUNT=10&FILTER_GEOM=POLYGON((8.2035381 44.901459,8.2035562 44.901459,8.2035562 44.901418,8.2035381 44.901418,8.2035381 44.901459))',
                                  'wms_getfeatureinfo_geometry_filter')
 
+        # Test feature info request with filter geometry in non-layer CRS
+        self.wms_request_compare('GetFeatureInfo',
+                                 '&layers=testlayer%20%C3%A8%C3%A9&' +
+                                 'INFO_FORMAT=text%2Fxml&' +
+                                 'width=600&height=400&srs=EPSG%3A3857&' +
+                                 'query_layers=testlayer%20%C3%A8%C3%A9&' +
+                                 'FEATURE_COUNT=10&FILTER_GEOM=POLYGON ((913213.6839952 5606021.5399693, 913215.6988780 5606021.5399693, 913215.6988780 5606015.09643322, 913213.6839952 5606015.0964332, 913213.6839952 5606021.5399693))',
+                                 'wms_getfeatureinfo_geometry_filter_3857')
+
         # Test feature info request with invalid query_layer
         self.wms_request_compare('GetFeatureInfo',
                                  '&layers=testlayer%20%C3%A8%C3%A9&' +
diff --git a/tests/testdata/qgis_server/wms_getfeatureinfo_geometry_filter.txt b/tests/testdata/qgis_server/wms_getfeatureinfo_geometry_filter.txt
@@ -7,7 +7,7 @@ Content-Type: text/xml; charset=utf-8
    <Attribute name="id" value="2"/>
    <Attribute name="name" value="two"/>
    <Attribute name="utf8nameè" value="two àò"/>
-   <BoundingBox CRS="EPSG:3857" minx="913214.6741" maxx="913214.6741" miny="5606017.8743" maxy="5606017.8743"/>
+   <BoundingBox CRS="EPSG:4326" minx="8.2035" maxx="8.2035" miny="44.9014" maxy="44.9014"/>
   </Feature>
  </Layer>
 </GetFeatureInfoResponse>
diff --git a/tests/testdata/qgis_server/wms_getfeatureinfo_geometry_filter_3857.txt b/tests/testdata/qgis_server/wms_getfeatureinfo_geometry_filter_3857.txt
@@ -0,0 +1,13 @@
+Content-Length: 261
+Content-Type: text/xml; charset=utf-8
+
+<GetFeatureInfoResponse>
+ <Layer name="testlayer èé">
+  <Feature id="1">
+   <Attribute name="id" value="2"/>
+   <Attribute name="name" value="two"/>
+   <Attribute name="utf8nameè" value="two àò"/>
+   <BoundingBox CRS="EPSG:3857" minx="913214.6741" maxx="913214.6741" miny="5606017.8743" maxy="5606017.8743"/>
+  </Feature>
+ </Layer>
+</GetFeatureInfoResponse>

Original file line number	Diff line number	Diff line change
`@@ -1358,6 +1358,16 @@ namespace QgsWms`
`1358`	`1358`	`return false;`
`1359`	`1359`	`}`
`1360`	`1360`
	`1361`	`+ QgsFeatureRequest fReq;`
	`1362`	`+`
	`1363`	`+ // Transform filter geometry to layer CRS`
	`1364`	`+ std::unique_ptr<QgsGeometry> layerFilterGeom;`
	`1365`	`+ if ( filterGeom )`
	`1366`	`+ {`
	`1367`	`+ layerFilterGeom.reset( new QgsGeometry( *filterGeom ) );`
	`1368`	`+ layerFilterGeom->transform( QgsCoordinateTransform( mapSettings.destinationCrs(), layer->crs(), fReq.transformContext() ) );`
	`1369`	`+ }`
	`1370`	`+`
`1361`	`1371`	`//we need a selection rect (0.01 of map width)`
`1362`	`1372`	`QgsRectangle mapRect = mapSettings.extent();`
`1363`	`1373`	`QgsRectangle layerRect = mapSettings.mapToLayerCoordinates( layer, mapRect );`
`@@ -1370,9 +1380,9 @@ namespace QgsWms`
`1370`	`1380`	`{`
`1371`	`1381`	`searchRect = featureInfoSearchRect( layer, mapSettings, renderContext, *infoPoint );`
`1372`	`1382`	`}`
`1373`		`- else if ( filterGeom )`
	`1383`	`+ else if ( layerFilterGeom )`
`1374`	`1384`	`{`
`1375`		`- searchRect = filterGeom->boundingBox();`
	`1385`	`+ searchRect = layerFilterGeom->boundingBox();`
`1376`	`1386`	`}`
`1377`	`1387`	`else if ( mParameters.contains( QStringLiteral( "BBOX" ) ) )`
`1378`	`1388`	`{`
`@@ -1390,8 +1400,7 @@ namespace QgsWms`
`1390`	`1400`	`bool segmentizeWktGeometry = QgsServerProjectUtils::wmsFeatureInfoSegmentizeWktGeometry( *mProject );`
`1391`	`1401`	`const QSet<QString> &excludedAttributes = layer->excludeAttributesWms();`
`1392`	`1402`
`1393`		`- QgsFeatureRequest fReq;`
`1394`		`- bool hasGeometry = addWktGeometry \|\| featureBBox \|\| filterGeom;`
	`1403`	`+ bool hasGeometry = addWktGeometry \|\| featureBBox \|\| layerFilterGeom;`
`1395`	`1404`	`fReq.setFlags( ( ( hasGeometry ) ? QgsFeatureRequest::NoFlags : QgsFeatureRequest::NoGeometry ) \| QgsFeatureRequest::ExactIntersect );`
`1396`	`1405`
`1397`	`1406`	`if ( ! searchRect.isEmpty() )`
`@@ -1403,9 +1412,10 @@ namespace QgsWms`
`1403`	`1412`	`fReq.setFlags( fReq.flags() & ~ QgsFeatureRequest::ExactIntersect );`
`1404`	`1413`	`}`
`1405`	`1414`
`1406`		`- if ( filterGeom )`
	`1415`	`+`
	`1416`	`+ if ( layerFilterGeom )`
`1407`	`1417`	`{`
`1408`		`- fReq.setFilterExpression( QString( "intersects( $geometry, geom_from_wkt('%1') )" ).arg( filterGeom->asWkt() ) );`
	`1418`	`+ fReq.setFilterExpression( QString( "intersects( $geometry, geom_from_wkt('%1') )" ).arg( layerFilterGeom->asWkt() ) );`
`1409`	`1419`	`}`
`1410`	`1420`
`1411`	`1421`	`#ifdef HAVE_SERVER_PYTHON_PLUGINS`