Disable the generated relations for poly rels in the relation dropdown

qgis · Jan 18, 2021 · 17deefe · 17deefe
1 parent d092770
commit 17deefe
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/gui/editorwidgets/qgsrelationreferenceconfigdlg.cpp b/src/gui/editorwidgets/qgsrelationreferenceconfigdlg.cpp
@@ -38,13 +38,17 @@ QgsRelationReferenceConfigDlg::QgsRelationReferenceConfigDlg( QgsVectorLayer *vl
   const auto constReferencingRelations = vl->referencingRelations( fieldIdx );
   for ( const QgsRelation &relation : constReferencingRelations )
   {
-    if ( relation.type() == QgsRelation::Generated )
-      continue;
-
     if ( relation.name().isEmpty() )
       mComboRelation->addItem( QStringLiteral( "%1 (%2)" ).arg( relation.id(), relation.referencedLayerId() ), relation.id() );
     else
       mComboRelation->addItem( QStringLiteral( "%1 (%2)" ).arg( relation.name(), relation.referencedLayerId() ), relation.id() );
+
+    QStandardItemModel *model = qobject_cast<QStandardItemModel *>( mComboRelation->model() );
+    QStandardItem *item = model->item( model->rowCount() - 1 );
+    item->setFlags( relation.type() == QgsRelation::Generated
+                    ? item->flags() & ~Qt::ItemIsEnabled
+                    : item->flags() | Qt::ItemIsEnabled );
+
     if ( auto *lReferencedLayer = relation.referencedLayer() )
     {
       mExpressionWidget->setField( lReferencedLayer->displayExpression() );

diff --git a/src/ui/editorwidgets/qgsrelationreferenceconfigdlgbase.ui b/src/ui/editorwidgets/qgsrelationreferenceconfigdlgbase.ui
@@ -30,6 +30,9 @@
    </item>
    <item row="1" column="1">
     <widget class="QComboBox" name="mComboRelation">
+     <property name="toolTip">
+      <string>The generated relations for a polymorphic relation cannot be used.</string>
+     </property>
      <property name="sizeAdjustPolicy">
       <enum>QComboBox::AdjustToMinimumContentsLengthWithIcon</enum>
      </property>