Skip to content

Commit 176a08c

Browse files
committedMar 23, 2013
[sextante]improved classes for creating unit tests from GUI
1 parent 9465afa commit 176a08c

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed
 

‎python/plugins/sextante/gui/HistoryDialog.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -86,19 +86,11 @@ def changeText(self):
8686
if isinstance(item, TreeLogEntryItem):
8787
self.text.setText(item.entry.text.replace("|","\n"))
8888

89-
90-
9189
def createTest(self):
9290
item = self.tree.currentItem()
9391
if isinstance(item, TreeLogEntryItem):
9492
if item.isAlg:
95-
TestTools.createTest(item)
96-
97-
98-
99-
100-
101-
93+
TestTools.createTest(item.entry.text)
10294

10395
def showPopupMenu(self,point):
10496
item = self.tree.currentItem()

‎python/plugins/sextante/gui/TestTools.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@
3232
from sextante.core.QGisLayers import QGisLayers
3333
from sextante.outputs.OutputVector import OutputVector
3434

35-
def createTest(item):
35+
def createTest(text):
3636
s = ""
37-
tokens = item.entry.text[len("sextante.runalg("):-1].split(",")
37+
tokens = text[len("sextante.runalg("):-1].split(",")
3838
cmdname = tokens[0][1:-1];
3939
methodname = "test_" + cmdname.replace(":","")
4040
s += "def " + methodname + "():\n"
@@ -44,7 +44,7 @@ def createTest(item):
4444
for token in tokens:
4545
if i < alg.getVisibleParametersCount() + 1:
4646
if os.path.exists(token[1:-1]):
47-
token = '"' + os.path.basename(token[1:-1])[:-4] + '"'
47+
token = os.path.basename(token[1:-1])[:-4]
4848
execcommand+=token + ","
4949
else:
5050
execcommand+="None,"
@@ -69,8 +69,8 @@ def createTest(item):
6969
fields = layer.pendingFields()
7070
s+="\tlayer=sextante.getobject(output)\n"
7171
s+="\tfields=layer.pendingFields()\n"
72-
s+="\texpectednames=[" + ",".join([str(f.name()) for f in fields]) + "]\n"
73-
s+="\texpectedtypes=[" + ",".join([str(f.typeName()) for f in fields]) + "]\n"
72+
s+="\texpectednames=[" + ",".join(["'" + str(f.name()) + "'" for f in fields]) + "]\n"
73+
s+="\texpectedtypes=[" + ",".join(["'" + str(f.typeName()) +"'" for f in fields]) + "]\n"
7474
s+="\tnames=[str(f.name()) for f in fields]\n"
7575
s+="\ttypes=[str(f.typeName()) for f in fields]\n"
7676
s+="\tself.assertEqual(expectednames, names)\n"

0 commit comments

Comments
 (0)
Please sign in to comment.