Fix crash when executing background threadable processing algorithms …

…on Windows Yet again processEvents() comes around to bite us in the butt.
qgis · Jan 22, 2018 · 16ebb26 · 16ebb26
1 parent 5fcd2dc
commit 16ebb26
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/gui/processing/qgsprocessingalgorithmdialogbase.cpp b/src/gui/processing/qgsprocessingalgorithmdialogbase.cpp
@@ -417,6 +417,16 @@ QString QgsProcessingAlgorithmDialogBase::formatHelp( QgsProcessingAlgorithm *al
 
 void QgsProcessingAlgorithmDialogBase::processEvents()
 {
+  if ( mAlgorithmTask )
+  {
+    // no need to call this - the algorithm is running in a thread.
+    // in fact, calling it causes a crash on Windows when the algorithm
+    // is running in a background thread... unfortunately we need something
+    // like this for non-threadable algorithms, otherwise there's no chance
+    // for users to hit cancel or see progress updates...
+    return;
+  }
+
   // So that we get a chance of hitting the Abort button
 #ifdef Q_OS_LINUX
   // For some reason on Windows hasPendingEvents() always return true,