Correctly create raster for heatmap output

nyalldawson · nyalldawson · commit 16ad87e8ed47 · 2017-07-21T10:39:32.000+10:00
Incorrect creation of geo transform was leading to invalid raster outputs and many "creating warped vrt" log messages (cherry-picked from 5241c74)
diff --git a/src/plugins/heatmap/heatmap.cpp b/src/plugins/heatmap/heatmap.cpp
@@ -149,7 +149,7 @@ void Heatmap::run()
     return;
   }
 
-  double geoTransform[6] = { myBBox.xMinimum(), cellsize, 0, myBBox.yMinimum(), 0, cellsize };
+  double geoTransform[6] = { myBBox.xMinimum(), cellsize, 0, myBBox.yMaximum(), 0, -cellsize };
   GDALDatasetH emptyDataset = GDALCreate( myDriver, d.outputFilename().toUtf8(), columns, rows, 1, GDT_Float32, nullptr );
   GDALSetGeoTransform( emptyDataset, geoTransform );
   // Set the projection on the raster destination to match the input layer
@@ -293,7 +293,7 @@ void Heatmap::run()
       // calculate the pixel position
       unsigned int xPosition, yPosition;
       xPosition = ((( *pointIt ).x() - myBBox.xMinimum() ) / cellsize ) - myBuffer;
-      yPosition = ((( *pointIt ).y() - myBBox.yMinimum() ) / cellsize ) - myBuffer;
+      yPosition = (( myBBox.yMaximum() - ( *pointIt ).y() ) / cellsize ) - myBuffer;
 
       // get the data
       float *dataBuffer = ( float * ) CPLMalloc( sizeof( float ) * blockSize * blockSize );
