Pass small object by value

nyalldawson · nyalldawson · commit 167e23e45e07 · 2018-08-20T20:07:24.000+10:00
diff --git a/src/analysis/vector/geometry_checker/qgsfeaturepool.cpp b/src/analysis/vector/geometry_checker/qgsfeaturepool.cpp
@@ -123,7 +123,7 @@ void QgsFeaturePool::updateFeature( QgsFeature &feature )
   mIndexMutex.unlock();
 }
 
-void QgsFeaturePool::deleteFeature( const QgsFeatureId &fid )
+void QgsFeaturePool::deleteFeature( QgsFeatureId fid )
 {
   QgsFeature origFeature;
   if ( get( fid, origFeature ) )
diff --git a/src/analysis/vector/geometry_checker/qgsfeaturepool.h b/src/analysis/vector/geometry_checker/qgsfeaturepool.h
@@ -38,7 +38,7 @@ class ANALYSIS_EXPORT QgsFeaturePool : public QObject
     bool get( QgsFeatureId id, QgsFeature &feature );
     void addFeature( QgsFeature &feature );
     void updateFeature( QgsFeature &feature );
-    void deleteFeature( const QgsFeatureId &fid );
+    void deleteFeature( QgsFeatureId fid );
     QgsFeatureIds getIntersects( const QgsRectangle &rect ) const;
     QgsVectorLayer *getLayer() const { return mLayer; }
     const QgsFeatureIds &getFeatureIds() const { return mFeatureIds; }

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ void QgsFeaturePool::updateFeature( QgsFeature &feature )`
`123`	`123`	`mIndexMutex.unlock();`
`124`	`124`	`}`
`125`	`125`
`126`		`-void QgsFeaturePool::deleteFeature( const QgsFeatureId &fid )`
	`126`	`+void QgsFeaturePool::deleteFeature( QgsFeatureId fid )`
`127`	`127`	`{`
`128`	`128`	`QgsFeature origFeature;`
`129`	`129`	`if ( get( fid, origFeature ) )`