avoid overriding method in subclass

qgis · Jan 16, 2023 · 166ad00 · 166ad00
1 parent 4fe0cbd
commit 166ad00
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/python/core/auto_generated/settings/qgssettingsentryimpl.sip.in b/python/core/auto_generated/settings/qgssettingsentryimpl.sip.in
@@ -84,7 +84,14 @@ This constructor is intended to be used from plugins.
     sipCpp = new sipQgsSettingsEntryVariant( QgsSettingsEntryVariant( *a0, QgsSettings::createPluginTreeElement( *a1 ), *a2, *a3, *a4 ) );
 %End
 
-    SIP_PYOBJECT value( SIP_PYOBJECT type = 0 ) const;
+
+
+    SIP_PYOBJECT valueAs( SIP_PYOBJECT type ) const;
+%Docstring
+Returns settings value.
+
+:param type: is the Python type of the value to be returned
+%End
 %MethodCode
     typedef PyObject *( *pyqt5_from_qvariant_by_type )( QVariant &value, PyObject *type );
     QVariant value;

diff --git a/python/pyplugin_installer/installer_data.py b/python/pyplugin_installer/installer_data.py
@@ -244,7 +244,7 @@ def timeForChecking(self) -> bool:
         settings = QgsSettings()
         try:
             # QgsSettings may contain ivalid value...
-            interval = QgsSettings.createPluginTreeElement("_plugin_manager").childSetting('check-on-start-last-date').value(type=QDate).daysTo(QDate.currentDate())
+            interval = QgsSettings.createPluginTreeElement("_plugin_manager").childSetting('check-on-start-last-date').valueAs(type=QDate).daysTo(QDate.currentDate())
         except:
             interval = 0
         if interval >= Repositories.CHECK_ON_START_INTERVAL:

diff --git a/src/core/settings/qgssettingsentryimpl.h b/src/core/settings/qgssettingsentryimpl.h
@@ -90,7 +90,14 @@ class CORE_EXPORT QgsSettingsEntryVariant : public QgsSettingsEntryByReference<Q
 #endif
 
 #ifdef SIP_RUN
-    SIP_PYOBJECT value( SIP_PYOBJECT type = 0 ) const;
+
+    /**
+     * Returns settings value.
+     *
+     * \param type is the Python type of the value to be returned
+     */
+
+    SIP_PYOBJECT valueAs( SIP_PYOBJECT type ) const;
     % MethodCode
     typedef PyObject *( *pyqt5_from_qvariant_by_type )( QVariant &value, PyObject *type );
     QVariant value;