Notify model of changes when renaming data items

nyalldawson · nyalldawson · commit 12e44b2016cd · 2017-12-14T15:44:51.000+10:00
diff --git a/python/core/qgsdataitem.sip b/python/core/qgsdataitem.sip
@@ -255,11 +255,22 @@ Create new data item.
 %Docstring
  :rtype: QIcon
 %End
+
     QString name() const;
 %Docstring
+ Returns the name of the item (the displayed text for the item).
+
+.. seealso:: :py:func:`setName()`
  :rtype: str
 %End
+
     void setName( const QString &name );
+%Docstring
+ Sets the ``name`` of the item (the displayed text for the item).
+
+.. seealso:: :py:func:`name()`
+%End
+
     QString path() const;
 %Docstring
  :rtype: str
diff --git a/src/core/qgsdataitem.cpp b/src/core/qgsdataitem.cpp
@@ -229,6 +229,12 @@ QIcon QgsDataItem::icon()
   return mIconMap.value( mIconName );
 }
 
+void QgsDataItem::setName( const QString &name )
+{
+  mName = name;
+  emit dataChanged( this );
+}
+
 QVector<QgsDataItem *> QgsDataItem::createChildren()
 {
   return QVector<QgsDataItem *>();
diff --git a/src/core/qgsdataitem.h b/src/core/qgsdataitem.h
@@ -248,8 +248,21 @@ class CORE_EXPORT QgsDataItem : public QObject
     void setParent( QgsDataItem *parent );
     QVector<QgsDataItem *> children() const { return mChildren; }
     virtual QIcon icon();
+
+    /**
+     * Returns the name of the item (the displayed text for the item).
+     *
+     * \see setName()
+     */
     QString name() const { return mName; }
-    void setName( const QString &name ) { mName = name; }
+
+    /**
+     * Sets the \a name of the item (the displayed text for the item).
+     *
+     * \see name()
+     */
+    void setName( const QString &name );
+
     QString path() const { return mPath; }
     void setPath( const QString &path ) { mPath = path; }
     //! Create path component replacing path separators

Original file line number	Diff line number	Diff line change
`@@ -229,6 +229,12 @@ QIcon QgsDataItem::icon()`
`229`	`229`	`return mIconMap.value( mIconName );`
`230`	`230`	`}`
`231`	`231`
	`232`	`+void QgsDataItem::setName( const QString &name )`
	`233`	`+{`
	`234`	`+ mName = name;`
	`235`	`+ emit dataChanged( this );`
	`236`	`+}`
	`237`	`+`
`232`	`238`	`QVector<QgsDataItem *> QgsDataItem::createChildren()`
`233`	`239`	`{`
`234`	`240`	`return QVector<QgsDataItem *>();`