Skip to content

Commit 121f46a

Browse files
authoredApr 18, 2023
Merge pull request #52736 from troopa81/fix_transaction_create_oracle
[Oracle] Fix transaction creation
2 parents bc114fb + 49e920b commit 121f46a

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
 

‎src/providers/oracle/qgsoracleconn.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ bool QgsOracleConn::execLogged( const QString &query, bool logError, QString *er
528528

529529
QSqlQuery qry( mDatabase );
530530

531-
const bool res { !exec( qry, query, QVariantList() ) };
531+
const bool res { exec( qry, query, QVariantList() ) };
532532

533533
logWrapper.setQuery( qry.lastQuery() );
534534

‎tests/src/python/test_provider_oracle.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -733,6 +733,16 @@ def testNestedInsert(self):
733733
f['pk'] = NULL
734734
self.vl.addFeature(f) # Should not deadlock during an active iteration
735735
f = next(it)
736+
self.vl.rollBack()
737+
738+
def testTransactionEditing(self):
739+
tg = QgsTransactionGroup()
740+
tg.addLayer(self.vl)
741+
self.vl.startEditing()
742+
feat = QgsFeature(self.vl.fields())
743+
feat.setAttribute("pk", 6)
744+
self.assertTrue(self.vl.addFeature(feat))
745+
self.vl.rollBack()
736746

737747
def testTimeout(self):
738748
"""

0 commit comments

Comments
 (0)
Please sign in to comment.