qgis · Jun 5, 2019
diff --git a/‎src/core/qgsvectorlayerutils.cpp
Lines changed: 13 additions & 1 deletion b/‎src/core/qgsvectorlayerutils.cpp
Lines changed: 13 additions & 1 deletion
diff --git a/‎tests/src/python/test_qgsvectorlayerutils.py
Lines changed: 25 additions & 1 deletion b/‎tests/src/python/test_qgsvectorlayerutils.py
Lines changed: 25 additions & 1 deletion
diff --git a/‎tests/testdata/humanbeings.gpkg
0 Bytes b/‎tests/testdata/humanbeings.gpkg
0 Bytes
diff --git a/‎tests/testdata/points_gpkg.gpkg
0 Bytes b/‎tests/testdata/points_gpkg.gpkg
0 Bytes
@@ -491,7 +491,19 @@ QgsFeatureList QgsVectorLayerUtils::createFeatures( const QgsVectorLayer *layer,
 
       // Cache unique values
       if ( hasUniqueConstraint && ! uniqueValueCaches.contains( idx ) )
-        uniqueValueCaches[ idx ] = layer->uniqueValues( idx );
+      {
+        // If the layer is filtered, get unique values from an unfiltered clone
+        if ( ! layer->subsetString().isEmpty() )
+        {
+          QgsVectorLayer *unfilteredClone { layer->clone( ) };
+          unfilteredClone->setSubsetString( QString( ) );
+          uniqueValueCaches[ idx ] = unfilteredClone->uniqueValues( idx );
+        }
+        else
+        {
+          uniqueValueCaches[ idx ] = layer->uniqueValues( idx );
+        }
+      }
 
       // 2. client side default expression
       // note - deliberately not using else if!
 
@@ -12,6 +12,8 @@
 
 import os
 import qgis  # NOQA
+import shutil
+import tempfile
 
 from qgis.PyQt.QtCore import QVariant
 from qgis.core import (QgsProject,
@@ -32,7 +34,7 @@
                        NULL
                        )
 from qgis.testing import start_app, unittest
-
+from utilities import unitTestDataPath
 
 start_app()
 
@@ -614,6 +616,28 @@ def test_create_nulls_and_defaults(self):
         for f in features:
             self.assertEqual(f.attributes()[0], 'my_default', f.id())
 
+    def test_unique_pk_when_subset(self):
+        """Test unique values on filtered layer GH #30062"""
+
+        src = unitTestDataPath('points_gpkg.gpkg')
+        dest = tempfile.mktemp() + '.gpkg'
+        shutil.copy(src, dest)
+        vl = QgsVectorLayer(dest, 'vl', 'ogr')
+        self.assertTrue(vl.isValid())
+        features_data = []
+        it = vl.getFeatures()
+        for _ in range(3):
+            f = next(it)
+            features_data.append(QgsVectorLayerUtils.QgsFeatureData(f.geometry(), dict(zip(range(f.fields().count()), f.attributes()))))
+        # Set a filter
+        vl.setSubsetString('"fid" in (4,5,6)')
+        self.assertTrue(vl.isValid())
+        context = vl.createExpressionContext()
+        features = QgsVectorLayerUtils.createFeatures(vl, features_data, context)
+        self.assertTrue(vl.startEditing())
+        vl.addFeatures(features)
+        self.assertTrue(vl.commitChanges())
+
 
 if __name__ == '__main__':
     unittest.main()