A joined feature is added only when one of its field is not null

qgis · Aug 28, 2017 · 11c62ca · 11c62ca
1 parent 927dea3
commit 11c62ca
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -2718,7 +2718,24 @@ bool QgsVectorLayer::addFeaturesToJoinedLayers( QgsFeatureList &features, Flags
           joinLayer->updateFeature( existingFeature );
         }
         else
-          joinFeatures << joinFeature;
+        {
+          // joined feature is added only if one of its field is not null
+          bool notNullFields = false;
+          Q_FOREACH ( const QgsField &field, joinFeature.fields() )
+          {
+            if ( field.name() == info.joinFieldName() )
+              continue;
+
+            if ( !joinFeature.attribute( field.name() ).isNull() )
+            {
+              notNullFields = true;
+              break;
+            }
+          }
+
+          if ( notNullFields )
+            joinFeatures << joinFeature;
+        }
       }
 
       joinLayer->addFeatures( joinFeatures );