Skip to content

Commit 11030dd

Browse files
authoredJan 10, 2018
Merge pull request #5522 from gacarrillor/developersmap
Developers Map: show more descriptive info
2 parents df3f663 + 70cb249 commit 11030dd

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed
 

‎doc/contributors.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"Committer": "Yes",
99
"First Commit Message": "Initial revision",
1010
"First Commit Date": "06-07-2002",
11-
"GIT Nickname": "gsherman"
11+
"GIT Nickname": "g-sherman"
1212
},
1313
"geometry": {
1414
"type": "Point",
@@ -141,7 +141,7 @@
141141
"Committer": "Yes",
142142
"First Commit Message": "some dutch translations for git testing",
143143
"First Commit Date": "4-9-2011",
144-
"GIT Nickname": "duiv"
144+
"GIT Nickname": "rduivenvoorde"
145145
},
146146
"geometry": {
147147
"type": "Point",
@@ -277,7 +277,7 @@
277277
"Committer": "Yes",
278278
"First Commit Message": "some bugfixes",
279279
"First Commit Date": "07-04-2004",
280-
"GIT Nickname": "rabla,rblazek,blazek"
280+
"GIT Nickname": "blazek"
281281
},
282282
"geometry": {
283283
"type": "Point",
@@ -334,7 +334,7 @@
334334
"type": "Point",
335335
"coordinates": [
336336
104.9110,
337-
11.5582
337+
11.5582
338338
]
339339
}
340340
},
@@ -644,7 +644,7 @@
644644
"Committer": "Yes",
645645
"First Commit Message": "Patch to allow setting extents from cli on startup",
646646
"First Commit Date": "03-06-2005",
647-
"GIT Nickname": "wonder"
647+
"GIT Nickname": "wonder-sk"
648648
},
649649
"geometry": {
650650
"type": "Point",

‎doc/developersmap.html

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,23 @@
1717
<script>
1818
var developersMapTiles = L.tileLayer('http://{s}.tile.osm.org/{z}/{x}/{y}.png', {
1919
maxZooom: 18,
20-
attribution: '&copy; <a href="http://osm.org/copyright">OpenStreetMap</a> contributors'
20+
attribution: '&copy; <a href="http://osm.org/copyright">OpenStreetMap</a> contributors'
2121
});
2222

2323
$.getJSON($('link[rel="points"]').attr("href"), function(data) {
24+
var nameString = '';
2425
var geojson = L.geoJson(data, {
2526
onEachFeature: function (feature, layer) {
26-
layer.bindPopup("<b>Name:</b> " + feature.properties.Name +
27-
"<br><b>Committer:</b> " + feature.properties.Committer);
27+
if (feature.properties['GIT Nickname'] !== undefined){
28+
nameString = "<a href='https://github.com/" +
29+
feature.properties['GIT Nickname'] + "' target='_blank' >" +
30+
feature.properties.Name + "</a>";
31+
} else {
32+
nameString = feature.properties.Name;
33+
}
34+
layer.bindPopup(nameString + "<br>" +
35+
(feature.properties.Committer == "Yes" ?
36+
"Core committer" : "Core contributor" ));
2837
}
2938
});
3039
var map = L.map('developers-map').fitBounds(geojson.getBounds());

0 commit comments

Comments
 (0)
Please sign in to comment.