more geometry validity checks

jef · jef · commit 10b080d28ffa · 2010-01-15T11:11:51.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@12767 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgsmaptoolnodetool.cpp b/src/app/qgsmaptoolnodetool.cpp
@@ -899,6 +899,11 @@ SelectionFeature::SelectionFeature()
 SelectionFeature::~SelectionFeature()
 {
   deleteVertexMap();
+
+  while ( !mGeomErrorMarkers.isEmpty() )
+  {
+    delete mGeomErrorMarkers.takeFirst();
+  }
 }
 
 void SelectionFeature::updateFeature()
@@ -1040,6 +1045,7 @@ void SelectionFeature::deleteSelectedVertexes()
   if ( count != 0 && ( !wasValid || isValid ) )
   {
     mVlayer->endEditCommand();
+    validateGeometry( f.geometry() );
   }
   else
   {
@@ -1151,11 +1157,6 @@ void SelectionFeature::deleteVertexMap()
     VertexEntry entry = mVertexMap.takeLast();
     delete entry.vertexMarker;
   }
-
-  while ( !mGeomErrorMarkers.isEmpty() )
-  {
-    delete mGeomErrorMarkers.takeFirst();
-  }
 }
 
 bool SelectionFeature::isSelected( int vertexNr )
diff --git a/src/core/qgsgeometry.cpp b/src/core/qgsgeometry.cpp
@@ -6324,27 +6324,46 @@ static bool ringInRing( const QgsPolyline &inside, const QgsPolyline &outside )
   return true;
 }
 
-bool ringIntersectsRing( const QgsPolyline &ring0, const QgsPolyline &ring1 )
+void QgsGeometry::checkRingIntersections( QList<Error> &errors,
+    int p0, int i0, const QgsPolyline &ring0,
+    int p1, int i1, const QgsPolyline &ring1 )
 {
-  bool inside = false;
-  bool outside = false;
-
-  for ( int i = 0; i < ring0.size(); i++ )
+  for ( int i = 0; i < ring0.size() - 1; i++ )
   {
-    if ( pointInRing( ring1, ring0[i] ) )
-    {
-      inside = true;
-    }
-    else
+    QgsVector v = ring0[i+1] - ring0[i];
+
+    for ( int j = 0; j < ring1.size() - 1; j++ )
     {
-      outside = true;
-    }
+      QgsVector w = ring1[j+1] - ring1[j];
 
-    if ( outside && inside )
-      return true;
-  }
+      QgsPoint s;
+      if ( intersectLines( ring0[i], v, ring1[j], w, s ) )
+      {
+        double d = -distLine2Point( ring0[i], v.perpVector(), s );
 
-  return false;
+        if ( d >= 0 && d <= v.length() )
+        {
+          d = -distLine2Point( ring1[j], w.perpVector(), s );
+          if ( d >= 0 && d <= w.length() )
+          {
+            QString msg = QObject::tr( "segment %1 of ring %2 of polygon %3 intersects segment %4 of ring %5 of polygon %6 at %7" )
+                          .arg( i0 ).arg( i ).arg( p0 )
+                          .arg( i1 ).arg( j ).arg( p1 )
+                          .arg( s.toString() );
+            QgsDebugMsg( msg );
+            errors << Error( msg, s );
+            if ( errors.size() > 100 )
+            {
+              QString msg = QObject::tr( "stopping validation after more than 100 errors" );
+              QgsDebugMsg( msg );
+              errors << Error( msg );
+              return;
+            }
+          }
+        }
+      }
+    }
+  }
 }
 
 void QgsGeometry::validatePolyline( QList<Error> &errors, int i, const QgsPolyline &line )
@@ -6406,6 +6425,7 @@ void QgsGeometry::validatePolyline( QList<Error> &errors, int i, const QgsPolyli
 
 void QgsGeometry::validatePolygon( QList<Error> &errors, int idx, const QgsPolygon &polygon )
 {
+  // check if holes are inside polygon
   for ( int i = 1; i < polygon.size(); i++ )
   {
     if ( !ringInRing( polygon[i], polygon[0] ) )
@@ -6416,19 +6436,16 @@ void QgsGeometry::validatePolygon( QList<Error> &errors, int idx, const QgsPolyg
     }
   }
 
+  // check holes for intersections
   for ( int i = 1; i < polygon.size(); i++ )
   {
     for ( int j = i + 1; j < polygon.size(); j++ )
     {
-      if ( ringIntersectsRing( polygon[i], polygon[j] ) )
-      {
-        QString msg = QObject::tr( "interior rings %1 and %2 of polygon %3 intersect" ).arg( i ).arg( j ).arg( idx );
-        QgsDebugMsg( msg );
-        errors << Error( msg );
-      }
+      checkRingIntersections( errors, idx, i, polygon[i], idx, j, polygon[j] );
     }
   }
 
+  // check if rings are self-intersecting
   for ( int i = 0; i < polygon.size(); i++ )
   {
     validatePolyline( errors, i, polygon[i] );
@@ -6473,7 +6490,28 @@ void QgsGeometry::validateGeometry( QList<Error> &errors )
     {
       QgsMultiPolygon mp = asMultiPolygon();
       for ( int i = 0; i < mp.size(); i++ )
+      {
         validatePolygon( errors, i, mp[i] );
+      }
+
+      for ( int i = 0; i < mp.size(); i++ )
+      {
+        for ( int j = i + 1;  j < mp.size(); j++ )
+        {
+          if ( ringInRing( mp[i][0], mp[j][0] ) )
+          {
+            errors << Error( QObject::tr( "polygon %1 inside polygon %2" ).arg( i ).arg( j ) );
+          }
+          else if ( ringInRing( mp[j][0], mp[i][0] ) )
+          {
+            errors << Error( QObject::tr( "polygon %1 inside polygon %2" ).arg( j ).arg( i ) );
+          }
+          else
+          {
+            checkRingIntersections( errors, i, 0, mp[i][0], j, 0, mp[j][0] );
+          }
+        }
+      }
     }
     break;
 
diff --git a/src/core/qgsgeometry.h b/src/core/qgsgeometry.h
@@ -511,6 +511,10 @@ class CORE_EXPORT QgsGeometry
     /** return polygon from wkb */
     QgsPolygon asPolygon( unsigned char*& ptr, bool hasZValue );
 
+    void checkRingIntersections( QList<Error> &errors,
+                                 int p0, int i0, const QgsPolyline &ring0,
+                                 int p1, int i1, const QgsPolyline &ring1 );
+
     void validatePolyline( QList<Error> &errors, int i, const QgsPolyline &polygon );
     void validatePolygon( QList<Error> &errors, int i, const QgsPolygon &polygon );
 

Original file line number	Diff line number	Diff line change
`@@ -899,6 +899,11 @@ SelectionFeature::SelectionFeature()`
`899`	`899`	`SelectionFeature::~SelectionFeature()`
`900`	`900`	`{`
`901`	`901`	`deleteVertexMap();`
	`902`	`+`
	`903`	`+ while ( !mGeomErrorMarkers.isEmpty() )`
	`904`	`+ {`
	`905`	`+ delete mGeomErrorMarkers.takeFirst();`
	`906`	`+ }`
`902`	`907`	`}`
`903`	`908`
`904`	`909`	`void SelectionFeature::updateFeature()`
`@@ -1040,6 +1045,7 @@ void SelectionFeature::deleteSelectedVertexes()`
`1040`	`1045`	`if ( count != 0 && ( !wasValid \|\| isValid ) )`
`1041`	`1046`	`{`
`1042`	`1047`	`mVlayer->endEditCommand();`
	`1048`	`+ validateGeometry( f.geometry() );`
`1043`	`1049`	`}`
`1044`	`1050`	`else`
`1045`	`1051`	`{`
`@@ -1151,11 +1157,6 @@ void SelectionFeature::deleteVertexMap()`
`1151`	`1157`	`VertexEntry entry = mVertexMap.takeLast();`
`1152`	`1158`	`delete entry.vertexMarker;`
`1153`	`1159`	`}`
`1154`		`-`
`1155`		`- while ( !mGeomErrorMarkers.isEmpty() )`
`1156`		`- {`
`1157`		`- delete mGeomErrorMarkers.takeFirst();`
`1158`		`- }`
`1159`	`1160`	`}`
`1160`	`1161`
`1161`	`1162`	`bool SelectionFeature::isSelected( int vertexNr )`