don't crash when reply is destroyed while it's waiting for credentials to be entered

jef-n · jef-n · commit 10a26e6acd8a · 2016-04-05T11:25:39.000+02:00
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -10907,8 +10907,9 @@ void QgisApp::namSetup()
 #endif
 }
 
-void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *auth )
+void QgisApp::namAuthenticationRequired( QNetworkReply *inReply, QAuthenticator *auth )
 {
+  QPointer<QNetworkReply> reply( inReply );
   Q_ASSERT( qApp->thread() == QThread::currentThread() );
 
   QString username = auth->user();
@@ -10943,7 +10944,7 @@ void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *a
     if ( !ok )
       return;
 
-    if ( reply->isFinished() )
+    if ( reply.isNull() || reply->isFinished() )
       return;
 
     if ( auth->user() != username || ( password != auth->password() && !password.isNull() ) )
