Fix virtual dispatch in constructor warnings

qgis · Apr 1, 2023 · 0ff713b · 0ff713b
1 parent a0dabca
commit 0ff713b
Show file tree

Hide file tree

Showing 16 changed files with 18 additions and 30 deletions.
diff --git a/python/gui/auto_generated/pointcloud/qgspointcloudrendererpropertieswidget.sip.in b/python/gui/auto_generated/pointcloud/qgspointcloudrendererpropertieswidget.sip.in
@@ -33,10 +33,8 @@ Constructor for QgsPointCloudRendererPropertiesWidget, associated with the speci
 Sets the ``context`` in which the widget is shown, e.g., the associated map canvas and expression contexts.
 %End
 
-    virtual void syncToLayer( QgsMapLayer *layer );
-
-    virtual void setDockMode( bool dockMode );
-
+    void syncToLayer( QgsMapLayer *layer ) final;
+    void setDockMode( bool dockMode ) final;
 
   public slots:
 

diff --git a/src/app/3d/qgsmeshlayer3drendererwidget.h b/src/app/3d/qgsmeshlayer3drendererwidget.h
@@ -36,7 +36,7 @@ class QgsMeshLayer3DRendererWidget : public QgsMapLayerConfigWidget
   public:
     explicit QgsMeshLayer3DRendererWidget( QgsMeshLayer *layer, QgsMapCanvas *canvas, QWidget *parent = nullptr );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
 
     //! no transfer of ownership
     void setRenderer( const QgsMeshLayer3DRenderer *renderer );

diff --git a/src/app/3d/qgspointcloudlayer3drendererwidget.h b/src/app/3d/qgspointcloudlayer3drendererwidget.h
@@ -36,8 +36,8 @@ class QgsPointCloudLayer3DRendererWidget : public QgsMapLayerConfigWidget
   public:
     explicit QgsPointCloudLayer3DRendererWidget( QgsPointCloudLayer *layer, QgsMapCanvas *canvas, QWidget *parent = nullptr );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
-    void setDockMode( bool dockMode ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
+    void setDockMode( bool dockMode ) final;
 
     //! no transfer of ownership
     void setRenderer( const QgsPointCloudLayer3DRenderer *renderer );

diff --git a/src/app/3d/qgsvectorlayer3drendererwidget.h b/src/app/3d/qgsvectorlayer3drendererwidget.h
@@ -65,7 +65,7 @@ class QgsVectorLayer3DRendererWidget : public QgsMapLayerConfigWidget
   public:
     explicit QgsVectorLayer3DRendererWidget( QgsMapLayer *layer, QgsMapCanvas *canvas, QWidget *parent = nullptr );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
 
     void setDockMode( bool dockMode ) override;
 

diff --git a/src/app/annotations/qgsannotationitempropertieswidget.h b/src/app/annotations/qgsannotationitempropertieswidget.h
@@ -33,9 +33,9 @@ class QgsAnnotationItemPropertiesWidget : public QgsMapLayerConfigWidget, public
     QgsAnnotationItemPropertiesWidget( QgsAnnotationLayer *layer, QgsMapCanvas *canvas, QWidget *parent );
     ~QgsAnnotationItemPropertiesWidget() override;
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
     void setMapLayerConfigWidgetContext( const QgsMapLayerConfigWidgetContext &context ) override;
-    void setDockMode( bool dockMode ) override;
+    void setDockMode( bool dockMode ) final;
 
   public slots:
     void apply() override;

diff --git a/src/app/mesh/qgsmeshelevationpropertieswidget.h b/src/app/mesh/qgsmeshelevationpropertieswidget.h
@@ -30,7 +30,7 @@ class QgsMeshElevationPropertiesWidget : public QgsMapLayerConfigWidget, private
 
     QgsMeshElevationPropertiesWidget( QgsMeshLayer *layer, QgsMapCanvas *canvas, QWidget *parent );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
 
   public slots:
     void apply() override;

diff --git a/src/app/qgslayertreegrouppropertieswidget.cpp b/src/app/qgslayertreegrouppropertieswidget.cpp
@@ -14,10 +14,8 @@
  ***************************************************************************/
 
 #include "qgslayertreegrouppropertieswidget.h"
-#include "qgsstyle.h"
 #include "qgsapplication.h"
 #include "qgsmaplayer.h"
-#include "qgsgui.h"
 #include "qgspainteffect.h"
 #include "qgsmapcanvas.h"
 #include "qgspainteffectregistry.h"

diff --git a/src/app/qgslayertreegrouppropertieswidget.h b/src/app/qgslayertreegrouppropertieswidget.h
@@ -33,9 +33,9 @@ class QgsLayerTreeGroupPropertiesWidget : public QgsMapLayerConfigWidget, public
     QgsLayerTreeGroupPropertiesWidget( QgsMapCanvas *canvas, QWidget *parent );
     ~QgsLayerTreeGroupPropertiesWidget() override;
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
     void setMapLayerConfigWidgetContext( const QgsMapLayerConfigWidgetContext &context ) override;
-    void setDockMode( bool dockMode ) override;
+    void setDockMode( bool dockMode ) final;
 
   public slots:
     void apply() override;

diff --git a/src/app/raster/qgsrasterelevationpropertieswidget.h b/src/app/raster/qgsrasterelevationpropertieswidget.h
@@ -30,7 +30,7 @@ class QgsRasterElevationPropertiesWidget : public QgsMapLayerConfigWidget, priva
 
     QgsRasterElevationPropertiesWidget( QgsRasterLayer *layer, QgsMapCanvas *canvas, QWidget *parent );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
 
   public slots:
     void apply() override;

diff --git a/src/app/vector/qgsvectorelevationpropertieswidget.h b/src/app/vector/qgsvectorelevationpropertieswidget.h
@@ -32,7 +32,7 @@ class QgsVectorElevationPropertiesWidget : public QgsMapLayerConfigWidget, priva
 
     QgsVectorElevationPropertiesWidget( QgsVectorLayer *layer, QgsMapCanvas *canvas, QWidget *parent );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
 
     QgsExpressionContext createExpressionContext() const override;
 

diff --git a/src/gui/mesh/qgsrenderermeshpropertieswidget.cpp b/src/gui/mesh/qgsrenderermeshpropertieswidget.cpp
@@ -18,11 +18,8 @@
 #include "qgis.h"
 #include "qgsmapcanvas.h"
 #include "qgsmeshlayer.h"
-#include "qgsmessagelog.h"
 #include "qgsmeshrendererscalarsettingswidget.h"
-#include "qgsmeshdatasetgrouptreeview.h"
 #include "qgsmeshrendereractivedatasetwidget.h"
-#include "qgsmeshlayerutils.h"
 #include "qgsproject.h"
 #include "qgsprojectutils.h"
 

diff --git a/src/gui/mesh/qgsrenderermeshpropertieswidget.h b/src/gui/mesh/qgsrenderermeshpropertieswidget.h
@@ -55,7 +55,7 @@ class GUI_EXPORT QgsRendererMeshPropertiesWidget : public QgsMapLayerConfigWidge
      *
      * \since QGIS 3.22, replace syncToLayer() without argument
      */
-    void syncToLayer( QgsMapLayer *mapLayer ) override;
+    void syncToLayer( QgsMapLayer *mapLayer ) final;
 
   public slots:
     //! Applies the settings made in the dialog

diff --git a/src/gui/pointcloud/qgspointcloudrendererpropertieswidget.h b/src/gui/pointcloud/qgspointcloudrendererpropertieswidget.h
@@ -51,8 +51,8 @@ class GUI_EXPORT QgsPointCloudRendererPropertiesWidget : public QgsMapLayerConfi
      */
     void setContext( const QgsSymbolWidgetContext &context );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
-    void setDockMode( bool dockMode ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
+    void setDockMode( bool dockMode ) final;
 
   public slots:
 

diff --git a/src/providers/postgres/raster/qgspostgresrastertemporalsettingswidget.cpp b/src/providers/postgres/raster/qgspostgresrastertemporalsettingswidget.cpp
@@ -17,12 +17,7 @@
 
 #include "qgspostgresrastertemporalsettingswidget.h"
 #include "qgsmaplayer.h"
-#include "qgsproject.h"
 #include "qgsrasterlayer.h"
-#include "qgsprojecttimesettings.h"
-#include "qgsrasterlayertemporalproperties.h"
-#include "qgsproviderregistry.h"
-#include "qgsprovidermetadata.h"
 
 QgsPostgresRasterTemporalSettingsWidget::QgsPostgresRasterTemporalSettingsWidget( QgsMapLayer *layer, QgsMapCanvas *canvas, QWidget *parent )
   : QgsMapLayerConfigWidget( layer, canvas, parent )

diff --git a/src/providers/postgres/raster/qgspostgresrastertemporalsettingswidget.h b/src/providers/postgres/raster/qgspostgresrastertemporalsettingswidget.h
@@ -31,7 +31,7 @@ class QgsPostgresRasterTemporalSettingsWidget : public QgsMapLayerConfigWidget,
   public:
     QgsPostgresRasterTemporalSettingsWidget( QgsMapLayer *layer, QgsMapCanvas *canvas, QWidget *parent = nullptr );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
     void apply() override;
   private slots:
 

diff --git a/src/providers/wms/qgswmstsettingswidget.h b/src/providers/wms/qgswmstsettingswidget.h
@@ -31,7 +31,7 @@ class QgsWmstSettingsWidget : public QgsMapLayerConfigWidget, private Ui::QgsWms
   public:
     QgsWmstSettingsWidget( QgsMapLayer *layer, QgsMapCanvas *canvas, QWidget *parent = nullptr );
 
-    void syncToLayer( QgsMapLayer *layer ) override;
+    void syncToLayer( QgsMapLayer *layer ) final;
     void apply() override;
   private slots:
     void temporalPropertiesChange();