Address review

qgis · Nov 8, 2022 · 0e5e393 · 0e5e393
1 parent 5093ae9
commit 0e5e393
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/core/labeling/qgsvectorlayerlabelprovider.cpp b/src/core/labeling/qgsvectorlayerlabelprovider.cpp
@@ -599,11 +599,11 @@ void QgsVectorLayerLabelProvider::drawLabelPrivate( pal::LabelPosition *label, Q
       for ( int blockIndex = 0; blockIndex < blockCount; ++blockIndex )
       {
         const double blockBaseLine = metrics.baselineOffset( blockIndex, Qgis::TextLayoutMode::Labeling );
-        painter->drawLine( QPointF( rect.left(), rect.top()  + blockBaseLine ), QPointF( rect.right(), rect.top() + blockBaseLine ) );
+        painter->drawLine( QPointF( rect.left(), rect.top()  + blockBaseLine ),
+                           QPointF( rect.right(), rect.top() + blockBaseLine ) );
       }
     }
 
-
     painter->restore();
   }
 

diff --git a/src/core/pal/labelposition.cpp b/src/core/pal/labelposition.cpp
@@ -546,7 +546,7 @@ const GEOSPreparedGeometry *LabelPosition::preparedOuterBoundsGeom() const
 
 double LabelPosition::getDistanceToPoint( double xp, double yp, bool useOuterBounds ) const
 {
-  // this method considers the label's outer bounds
+  // this method may consider the label's outer bounds!
 
   GEOSContextHandle_t geosctxt = QgsGeos::getGEOSHandler();
 

diff --git a/src/core/pal/labelposition.h b/src/core/pal/labelposition.h
@@ -138,6 +138,10 @@ namespace pal
 
       /**
        * Gets distance from this label to a point. If point lies inside, returns negative number.
+       *
+       * If \a useOuterBounds is TRUE then the distance will be calculated to the outer bounds
+       * of the label (see QgsLabelFeature::outerBounds()), otherwise it will be calculated
+       * to the label's actual rectangle.
        */
       double getDistanceToPoint( double xp, double yp, bool useOuterBounds ) const;