Use QString::at(0) instead of left(1), since it's more efficient

nyalldawson · nyalldawson · commit 0b940cacccdc · 2016-05-15T20:50:43.000+10:00
and doesn't allocate a QString
diff --git a/src/app/qgsabout.cpp b/src/app/qgsabout.cpp
@@ -87,7 +87,7 @@ void QgsAbout::init()
     {
       line = stream.readLine(); // line of text excluding '\n'
       //ignore the line if it starts with a hash....
-      if ( line.left( 1 ) == "#" )
+      if ( line.at( 0 ) == '#' )
         continue;
       QStringList myTokens = line.split( '\t', QString::SkipEmptyParts );
       lines << myTokens[0];
@@ -119,7 +119,7 @@ void QgsAbout::init()
     {
       line = stream.readLine(); // line of text excluding '\n'
       //ignore the line if it starts with a hash....
-      if ( line.left( 1 ) == "#" )
+      if ( line.at( 0 ) == '#' )
         continue;
       lines += line;
     }
diff --git a/src/core/qgsexpression.cpp b/src/core/qgsexpression.cpp
@@ -648,7 +648,7 @@ static QVariant fcnTitle( const QVariantList& values, const QgsExpressionContext
   for ( int i = 0; i < elems.size(); i++ )
   {
     if ( elems[i].size() > 1 )
-      elems[i] = elems[i].left( 1 ).toUpper() + elems[i].mid( 1 ).toLower();
+      elems[i] = elems[i].at( 0 ).toUpper() + elems[i].mid( 1 ).toLower();
   }
   return QVariant( elems.join( " " ) );
 }
diff --git a/src/core/qgsmaplayer.cpp b/src/core/qgsmaplayer.cpp
@@ -1027,7 +1027,7 @@ QString QgsMapLayer::capitaliseLayerName( const QString& name )
   QString layerName( name );
 
   if ( capitaliseLayerName )
-    layerName = layerName.left( 1 ).toUpper() + layerName.mid( 1 );
+    layerName = layerName.at( 0 ).toUpper() + layerName.mid( 1 );
 
   return layerName;
 }
diff --git a/src/providers/spatialite/qspatialite/qsql_spatialite.cpp b/src/providers/spatialite/qspatialite/qsql_spatialite.cpp
@@ -72,7 +72,7 @@ QT_BEGIN_NAMESPACE
 static QString _q_escapeIdentifier(const QString &identifier)
 {
     QString res = identifier;
-    if(!identifier.isEmpty() && identifier.left(1) != QString(QLatin1Char('"')) && identifier.right(1) != QString(QLatin1Char('"')) ) {
+    if(!identifier.isEmpty() && identifier.at(0) != '"' && identifier.right(1) != QString(QLatin1Char('"')) ) {
         res.replace(QLatin1Char('"'), QLatin1String("\"\""));
         res.prepend(QLatin1Char('"')).append(QLatin1Char('"'));
         res.replace(QLatin1Char('.'), QLatin1String("\".\""));

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ void QgsAbout::init()`
`87`	`87`	`{`
`88`	`88`	`line = stream.readLine(); // line of text excluding '\n'`
`89`	`89`	`//ignore the line if it starts with a hash....`
`90`		`- if ( line.left( 1 ) == "#" )`
	`90`	`+ if ( line.at( 0 ) == '#' )`
`91`	`91`	`continue;`
`92`	`92`	`QStringList myTokens = line.split( '\t', QString::SkipEmptyParts );`
`93`	`93`	`lines << myTokens[0];`
`@@ -119,7 +119,7 @@ void QgsAbout::init()`
`119`	`119`	`{`
`120`	`120`	`line = stream.readLine(); // line of text excluding '\n'`
`121`	`121`	`//ignore the line if it starts with a hash....`
`122`		`- if ( line.left( 1 ) == "#" )`
	`122`	`+ if ( line.at( 0 ) == '#' )`
`123`	`123`	`continue;`
`124`	`124`	`lines += line;`
`125`	`125`	`}`
Original file line number	Diff line number	Diff line change
`@@ -648,7 +648,7 @@ static QVariant fcnTitle( const QVariantList& values, const QgsExpressionContext`
`648`	`648`	`for ( int i = 0; i < elems.size(); i++ )`
`649`	`649`	`{`
`650`	`650`	`if ( elems[i].size() > 1 )`
`651`		`- elems[i] = elems[i].left( 1 ).toUpper() + elems[i].mid( 1 ).toLower();`
	`651`	`+ elems[i] = elems[i].at( 0 ).toUpper() + elems[i].mid( 1 ).toLower();`
`652`	`652`	`}`
`653`	`653`	`return QVariant( elems.join( " " ) );`
`654`	`654`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1027,7 +1027,7 @@ QString QgsMapLayer::capitaliseLayerName( const QString& name )`
`1027`	`1027`	`QString layerName( name );`
`1028`	`1028`
`1029`	`1029`	`if ( capitaliseLayerName )`
`1030`		`- layerName = layerName.left( 1 ).toUpper() + layerName.mid( 1 );`
	`1030`	`+ layerName = layerName.at( 0 ).toUpper() + layerName.mid( 1 );`
`1031`	`1031`
`1032`	`1032`	`return layerName;`
`1033`	`1033`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ QT_BEGIN_NAMESPACE`
`72`	`72`	`static QString _q_escapeIdentifier(const QString &identifier)`
`73`	`73`	`{`
`74`	`74`	`QString res = identifier;`
`75`		`- if(!identifier.isEmpty() && identifier.left(1) != QString(QLatin1Char('"')) && identifier.right(1) != QString(QLatin1Char('"')) ) {`
	`75`	`+ if(!identifier.isEmpty() && identifier.at(0) != '"' && identifier.right(1) != QString(QLatin1Char('"')) ) {`
`76`	`76`	`res.replace(QLatin1Char('"'), QLatin1String("\"\""));`
`77`	`77`	`res.prepend(QLatin1Char('"')).append(QLatin1Char('"'));`
`78`	`78`	`res.replace(QLatin1Char('.'), QLatin1String("\".\""));`