[offline editing] fix overwriting of first field on remote layer when…

… it has virtual fields (#45003)
qgis · Sep 9, 2021 · 0a9afa0 · 0a9afa0
1 parent 0a7bcf3
commit 0a9afa0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/core/qgsofflineediting.cpp b/src/core/qgsofflineediting.cpp
@@ -963,12 +963,15 @@ void QgsOfflineEditing::applyFeaturesAdded( QgsVectorLayer *offlineLayer, QgsVec
   {
     // NOTE: SpatiaLite provider ignores position of geometry column
     // restore gap in QgsAttributeMap if geometry column is not last (WORKAROUND)
-    QMap<int, int> attrLookup = attributeLookup( offlineLayer, remoteLayer );
+    const QMap<int, int> attrLookup = attributeLookup( offlineLayer, remoteLayer );
     QgsAttributes newAttrs( newAttrsCount );
     QgsAttributes attrs = it->attributes();
     for ( int it = 0; it < attrs.count(); ++it )
     {
-      int remoteAttributeIndex = attrLookup[ it ];
+      const int remoteAttributeIndex = attrLookup.value( it, -1 );
+      // if virtual or non existing field
+      if ( remoteAttributeIndex == -1 )
+        continue;
       QVariant attr = attrs.at( it );
       if ( remoteLayer->fields().at( remoteAttributeIndex ).type() == QVariant::StringList )
       {
@@ -1614,4 +1617,3 @@ void QgsOfflineEditing::setupLayer( QgsMapLayer *layer )
     }
   }
 }
-