Address comments

qgis · Apr 22, 2021 · 0a76d70 · 0a76d70
1 parent 584283d
commit 0a76d70
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/python/core/auto_generated/network/qgsnetworkaccessmanager.sip.in b/python/core/auto_generated/network/qgsnetworkaccessmanager.sip.in
@@ -325,12 +325,20 @@ The contents of the reply will be returned after the request is completed or an
 %Docstring
 Forwards an external browser login ``url`` opening request to the authentication handler.
 
+.. note::
+
+   If called by a background thread, the request will be forwarded to the network manager on the main thread.
+
 .. versionadded:: 3.20
 %End
 
     void requestAuthCloseBrowser() const;
 %Docstring
-Forwards an external browser login closure equest to the authentication handler.
+Forwards an external browser login closure request to the authentication handler.
+
+.. note::
+
+   If called by a background thread, the request will be forwarded to the network manager on the main thread.
 
 .. versionadded:: 3.20
 %End

diff --git a/src/core/network/qgsnetworkaccessmanager.h b/src/core/network/qgsnetworkaccessmanager.h
@@ -516,13 +516,15 @@ class CORE_EXPORT QgsNetworkAccessManager : public QNetworkAccessManager
     /**
      * Forwards an external browser login \a url opening request to the authentication handler.
      *
+     * \note If called by a background thread, the request will be forwarded to the network manager on the main thread.
      * \since QGIS 3.20
      */
     void requestAuthOpenBrowser( const QUrl &url ) const;
 
     /**
-     * Forwards an external browser login closure equest to the authentication handler.
+     * Forwards an external browser login closure request to the authentication handler.
      *
+     * \note If called by a background thread, the request will be forwarded to the network manager on the main thread.
      * \since QGIS 3.20
      */
     void requestAuthCloseBrowser() const;