Clazy warnings

nyalldawson · nyalldawson · commit 0a02432b0cc0 · 2018-10-25T10:51:44.000+10:00
diff --git a/src/gui/qgsmessagebaritem.cpp b/src/gui/qgsmessagebaritem.cpp
@@ -116,29 +116,29 @@ void QgsMessageBarItem::writeContent()
   QString contentStyleSheet;
   if ( mLevel == Qgis::Success )
   {
-    mStyleSheet = "QgsMessageBar { background-color: #dff0d8; border: 1px solid #8e998a; } "
-                  "QLabel,QTextEdit { color: black; } ";
-    contentStyleSheet = "<style> a, a:visited, a:hover { color:#268300; } </style>";
+    mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #dff0d8; border: 1px solid #8e998a; } "
+                                  "QLabel,QTextEdit { color: black; } " );
+    contentStyleSheet = QStringLiteral( "<style> a, a:visited, a:hover { color:#268300; } </style>" );
   }
   else if ( mLevel == Qgis::Critical )
   {
-    mStyleSheet = "QgsMessageBar { background-color: #d65253; border: 1px solid #9b3d3d; } "
-                  "QLabel,QTextEdit { color: white; } ";
-    contentStyleSheet = "<style>a, a:visited, a:hover { color:#4e0001; }</style>";
+    mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #d65253; border: 1px solid #9b3d3d; } "
+                                  "QLabel,QTextEdit { color: white; } " );
+    contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#4e0001; }</style>" );
   }
   else if ( mLevel == Qgis::Warning )
   {
-    mStyleSheet = "QgsMessageBar { background-color: #ffc800; border: 1px solid #e0aa00; } "
-                  "QLabel,QTextEdit { color: black; } ";
-    contentStyleSheet = "<style>a, a:visited, a:hover { color:#945a00; }</style>";
+    mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #ffc800; border: 1px solid #e0aa00; } "
+                                  "QLabel,QTextEdit { color: black; } " );
+    contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#945a00; }</style>" );
   }
   else if ( mLevel == Qgis::Info )
   {
-    mStyleSheet = "QgsMessageBar { background-color: #e7f5fe; border: 1px solid #b9cfe4; } "
-                  "QLabel,QTextEdit { color: #2554a1; } ";
-    contentStyleSheet = "<style>a, a:visited, a:hover { color:#3bb2fe; }</style>";
+    mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #e7f5fe; border: 1px solid #b9cfe4; } "
+                                  "QLabel,QTextEdit { color: #2554a1; } " );
+    contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#3bb2fe; }</style>" );
   }
-  mStyleSheet += QLatin1String( "QLabel#mItemCount { font-style: italic; }" );
+  mStyleSheet += QStringLiteral( "QLabel#mItemCount { font-style: italic; }" );
 
   // TITLE AND TEXT
   if ( mTitle.isEmpty() && mText.isEmpty() )

Original file line number	Diff line number	Diff line change
`@@ -116,29 +116,29 @@ void QgsMessageBarItem::writeContent()`
`116`	`116`	`QString contentStyleSheet;`
`117`	`117`	`if ( mLevel == Qgis::Success )`
`118`	`118`	`{`
`119`		`- mStyleSheet = "QgsMessageBar { background-color: #dff0d8; border: 1px solid #8e998a; } "`
`120`		`- "QLabel,QTextEdit { color: black; } ";`
`121`		`- contentStyleSheet = "<style> a, a:visited, a:hover { color:#268300; } </style>";`
	`119`	`+ mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #dff0d8; border: 1px solid #8e998a; } "`
	`120`	`+ "QLabel,QTextEdit { color: black; } " );`
	`121`	`+ contentStyleSheet = QStringLiteral( "<style> a, a:visited, a:hover { color:#268300; } </style>" );`
`122`	`122`	`}`
`123`	`123`	`else if ( mLevel == Qgis::Critical )`
`124`	`124`	`{`
`125`		`- mStyleSheet = "QgsMessageBar { background-color: #d65253; border: 1px solid #9b3d3d; } "`
`126`		`- "QLabel,QTextEdit { color: white; } ";`
`127`		`- contentStyleSheet = "<style>a, a:visited, a:hover { color:#4e0001; }</style>";`
	`125`	`+ mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #d65253; border: 1px solid #9b3d3d; } "`
	`126`	`+ "QLabel,QTextEdit { color: white; } " );`
	`127`	`+ contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#4e0001; }</style>" );`
`128`	`128`	`}`
`129`	`129`	`else if ( mLevel == Qgis::Warning )`
`130`	`130`	`{`
`131`		`- mStyleSheet = "QgsMessageBar { background-color: #ffc800; border: 1px solid #e0aa00; } "`
`132`		`- "QLabel,QTextEdit { color: black; } ";`
`133`		`- contentStyleSheet = "<style>a, a:visited, a:hover { color:#945a00; }</style>";`
	`131`	`+ mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #ffc800; border: 1px solid #e0aa00; } "`
	`132`	`+ "QLabel,QTextEdit { color: black; } " );`
	`133`	`+ contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#945a00; }</style>" );`
`134`	`134`	`}`
`135`	`135`	`else if ( mLevel == Qgis::Info )`
`136`	`136`	`{`
`137`		`- mStyleSheet = "QgsMessageBar { background-color: #e7f5fe; border: 1px solid #b9cfe4; } "`
`138`		`- "QLabel,QTextEdit { color: #2554a1; } ";`
`139`		`- contentStyleSheet = "<style>a, a:visited, a:hover { color:#3bb2fe; }</style>";`
	`137`	`+ mStyleSheet = QStringLiteral( "QgsMessageBar { background-color: #e7f5fe; border: 1px solid #b9cfe4; } "`
	`138`	`+ "QLabel,QTextEdit { color: #2554a1; } " );`
	`139`	`+ contentStyleSheet = QStringLiteral( "<style>a, a:visited, a:hover { color:#3bb2fe; }</style>" );`
`140`	`140`	`}`
`141`		`- mStyleSheet += QLatin1String( "QLabel#mItemCount { font-style: italic; }" );`
	`141`	`+ mStyleSheet += QStringLiteral( "QLabel#mItemCount { font-style: italic; }" );`
`142`	`142`
`143`	`143`	`// TITLE AND TEXT`
`144`	`144`	`if ( mTitle.isEmpty() && mText.isEmpty() )`